Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prototype pollution vulnerability #69

Merged
merged 6 commits into from
May 19, 2021
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Reset prototype of XML after parsing
yadhukrishnam committed May 18, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 9e569b71967d439265d7c5b0e72d97b678641ed4
2 changes: 2 additions & 0 deletions index.js
Original file line number Diff line number Diff line change
@@ -43,6 +43,8 @@ module.exports = function (bodyParser) {
return next(err);
}

// Set the prototype of parsed xml object to null, so that prototype pollution is prevented.
xml.__proto__ = undefined;
req.body = xml || req.body;
next();
});