Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Union schema compatibility #45

Merged
merged 9 commits into from
Oct 12, 2023

Conversation

fivetran-catfritz
Copy link
Contributor

@fivetran-catfritz fivetran-catfritz commented Aug 29, 2023

Issue: #46

Confirm the following files were correctly updated automatically:

  • CHANGELOG
  • README
  • stg_apple_search_ads.yml, src_apple_search_ads.yml, apple_search_ads.yml (depending if source or transform)
  • docs.md
  • joins
  • window functions (partition by)
  • 'source_relation' column added in staging and transform models
  • tests

Manual updates:

  • Add source_relation to downstream models if necessary
  • Finish any incomplete/incorrect joins/partitions
  • Update tests to include source_relation in unique-combination-of-cols if necessary
    • May need to remove some uniqueness tests in favor of the combo test

Validation:

  • dbt run locally passes
  • dbt test locally passes

@fivetran-catfritz fivetran-catfritz self-assigned this Aug 31, 2023
@fivetran-catfritz fivetran-catfritz linked an issue Aug 31, 2023 that may be closed by this pull request
4 tasks
@fivetran-catfritz
Copy link
Contributor Author

Note--we need to decide if we update identifier for ad_level_report table or update fivetran_utils.union_data to handle divergent naming.

It technically passes buildkite, but reviewing the logs, it can't find a lot of the seed tables because of the identifier issues, which would mean problems for others using identifiers.

Copy link
Collaborator

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a few small comments to make minor updates to the README and packages.yml before merging.

Again let's hold off to release until we can do them all together. Otherwise, this looks good to go!

CHANGELOG.md Outdated Show resolved Hide resolved
packages.yml Outdated Show resolved Hide resolved
@fivetran-catfritz
Copy link
Contributor Author

Merging for release on 12-Oct-2023.

@fivetran-catfritz fivetran-catfritz merged commit 536a8a6 into main Oct 12, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add union schema capability
2 participants