Fix enabled config to handle conditionals #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fivetran-joemarkiewicz
approved these changes
Jan 5, 2023
There was a problem hiding this comment.
This looks great @nszoni! Thanks so much for taking the time to contribute back to our packages to fix the issue you originally discovered! 🏅
I am approving this PR, but I have one small request for you to add a contributor section to the CHANGELOG. Once that is applied I will be able to merge this and incorporate in the next patch release!
fivetran-joemarkiewicz
added
type:bug
|
Brilliant!! Thanks so much for the quick turnaround @nszoni! These updates look great to me and I will kick off our internal process to merge and cut the release 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Are you a current Fivetran customer?
No, I'm Sonny Nguyen, Analytics Engineer from Hiflylabs:)
What change(s) does this PR introduce?
Fixes a bug switching off the
apple_search_ads.search_term_reportsource. Previously, it wasn't able to compile the Jinja expression because theandparameter was outside the context. This achieves the intended behaviour.Did you update the CHANGELOG?
Does this PR introduce a breaking change?
It only disables the source when the right
varsare defined as False as intended.Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)
Is this PR in response to a previously created Bug or Feature Request
How did you test the PR changes?
Select which warehouse(s) were used to test the PR
Provide an emoji that best describes your current mood
💃
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.