Skip to content

Commit

Permalink
Merge pull request #42 from fivetran/bugfix/search-term-passthrough
Browse files Browse the repository at this point in the history
bugfix/search-term-passthrough
  • Loading branch information
fivetran-joemarkiewicz committed May 25, 2023
2 parents 2b5e2dc + 06ba71b commit 6c4c1ef
Show file tree
Hide file tree
Showing 9 changed files with 21 additions and 21 deletions.
12 changes: 6 additions & 6 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
# dbt_apple_search_ads_source v0.UPDATE.UPDATE

## Under the Hood:

- Incorporated the new `fivetran_utils.drop_schemas_automation` macro into the end of each Buildkite integration test job.
- Updated the pull request [templates](/.github).
# dbt_apple_search_ads_source v0.2.2
## Bug Fix
- The `apple_search_ads__search_term_passthrough_metrics` variable was moved to be within the return call of the `get_search_term_report_columns` macro. The previous placement caused an issue where the passthrough metrics would not properly persist to downstream models. ([PR #42](https://github.com/fivetran/dbt_apple_search_ads_source/pull/42))
## Under the Hood:
- Incorporated the new `fivetran_utils.drop_schemas_automation` macro into the end of each Buildkite integration test job. ([PR #40](https://github.com/fivetran/dbt_apple_search_ads_source/pull/40))
- Updated the pull request [templates](/.github). ([PR #40](https://github.com/fivetran/dbt_apple_search_ads_source/pull/40))
# dbt_apple_search_ads_source v0.2.1

## 🕷️ Bugfixes 🕷️
Expand Down
2 changes: 1 addition & 1 deletion dbt_project.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: 'apple_search_ads_source'
version: '0.2.1'
version: '0.2.2'

config-version: 2
require-dbt-version: [">=1.3.0", "<2.0.0"]
Expand Down
2 changes: 1 addition & 1 deletion docs/catalog.json

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions docs/index.html

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion docs/manifest.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion docs/run_results.json

Large diffs are not rendered by default.

10 changes: 5 additions & 5 deletions integration_tests/ci/sample.profiles.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,13 @@ integration_tests:
pass: "{{ env_var('CI_REDSHIFT_DBT_PASS') }}"
dbname: "{{ env_var('CI_REDSHIFT_DBT_DBNAME') }}"
port: 5439
schema: apple_ads_source_integrations_tests
schema: apple_ads_source_integrations_tests_1
threads: 8
bigquery:
type: bigquery
method: service-account-json
project: 'dbt-package-testing'
schema: apple_ads_source_integrations_tests
schema: apple_ads_source_integrations_tests_1
threads: 8
keyfile_json: "{{ env_var('GCLOUD_SERVICE_KEY') | as_native }}"
snowflake:
Expand All @@ -33,7 +33,7 @@ integration_tests:
role: "{{ env_var('CI_SNOWFLAKE_DBT_ROLE') }}"
database: "{{ env_var('CI_SNOWFLAKE_DBT_DATABASE') }}"
warehouse: "{{ env_var('CI_SNOWFLAKE_DBT_WAREHOUSE') }}"
schema: apple_ads_source_integrations_tests
schema: apple_ads_source_integrations_tests_1
threads: 8
postgres:
type: postgres
Expand All @@ -42,13 +42,13 @@ integration_tests:
pass: "{{ env_var('CI_POSTGRES_DBT_PASS') }}"
dbname: "{{ env_var('CI_POSTGRES_DBT_DBNAME') }}"
port: 5432
schema: apple_ads_source_integrations_tests
schema: apple_ads_source_integrations_tests_1
threads: 8
databricks:
catalog: null
host: "{{ env_var('CI_DATABRICKS_DBT_HOST') }}"
http_path: "{{ env_var('CI_DATABRICKS_DBT_HTTP_PATH') }}"
schema: apple_ads_source_integrations_tests
schema: apple_ads_source_integrations_tests_1
threads: 2
token: "{{ env_var('CI_DATABRICKS_DBT_TOKEN') }}"
type: databricks
4 changes: 2 additions & 2 deletions integration_tests/dbt_project.yml
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
config-version: 2

name: 'apple_search_ads_source_integration_tests'
version: '0.2.1'
version: '0.2.2'

profile: 'integration_tests'

vars:
apple_search_ads_schema: apple_ads_source_integrations_tests
apple_search_ads_schema: apple_ads_source_integrations_tests_1
apple_search_ads_organization_identifier: "organization_data"
apple_search_ads_campaign_history_identifier: "campaign_history_data"
apple_search_ads_campaign_report_identifier: "campaign_report_data"
Expand Down
4 changes: 2 additions & 2 deletions macros/get_search_term_report_columns.sql
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@
{"name": "taps", "datatype": dbt.type_int()}
] %}

{{ return(columns) }}

{{ fivetran_utils.add_pass_through_columns(columns, var('apple_search_ads__search_term_passthrough_metrics')) }}

{{ return(columns) }}

{% endmacro %}

0 comments on commit 6c4c1ef

Please sign in to comment.