Documentation Standard Updates #23
Merged
+106
−70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlmendgom5TRAN
approved these changes
Aug 26, 2024
There was a problem hiding this comment.
@fivetran-joemarkiewicz One quick question before I approve, one the be checkboxes say Renaming **models to **tables** (only for transform repos). Is that meant that all instances of "models" should be "tables" or just in the table with the table and its description? For example, L22 calls them models instead of tables.
|
@fivetran-catfritz great callout. We will want to make sure the wording rendered in the Quickstart UI is referring to "tables". So in your callout we will want to make that update. But we can leave the other non UI references as models. I just made the update. Let me know if you have other questions. |
fivetran-catfritz
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request was created automatically 🎉:
.github/files have been properly updated (templates are updated and auto releaser is included).quickstart/quickstart.ymlfile aspublic_models(only for transform repos)**modelsto**tables**(only for transform repos)