Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Union schema compatibility #20

Merged
merged 9 commits into from
Oct 12, 2023

Conversation

fivetran-catfritz
Copy link
Contributor

@fivetran-catfritz fivetran-catfritz commented Aug 29, 2023

Issue: #21

Confirm the following files were correctly updated automatically:

  • CHANGELOG
  • README
  • stg_apple_search_ads.yml, src_apple_search_ads.yml, apple_search_ads.yml (depending if source or transform)
  • docs.md
  • joins
  • window functions (partition by)
  • 'source_relation' column added in staging and transform models
  • tests

Manual updates:

  • Add source_relation to downstream models if necessary
  • Finish any incomplete/incorrect joins/partitions
  • Update tests to include source_relation in unique-combination-of-cols if necessary
    • May need to remove some uniqueness tests in favor of the combo test

Validation:

  • dbt run locally passes
  • dbt test locally passes

@fivetran-catfritz fivetran-catfritz linked an issue Aug 31, 2023 that may be closed by this pull request
4 tasks
@fivetran-catfritz fivetran-catfritz self-assigned this Aug 31, 2023
Copy link
Collaborator

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These updates look great! I have one small comment about updating the README and CHANGELOG. Once those are applied then this should be ready to merge once the others are all approved.

CHANGELOG.md Outdated Show resolved Hide resolved
packages.yml Outdated Show resolved Hide resolved
@AaronCoquet-Easypark
Copy link

When should we expect this to be merged? Is there anything left to be done?

@fivetran-catfritz
Copy link
Contributor Author

Hi @AaronCoquet-Easypark we are going through final validations for this package and its integration into our rollup ad_reporting package. We are planning to release this in the next week or two.

@fivetran-catfritz fivetran-catfritz merged commit 8c96517 into main Oct 12, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add union schema capability
3 participants