Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: add additional columns for unique column combination test for apple_search_ads__search_term_report #17

Conversation

yuna-tang
Copy link
Contributor

@yuna-tang yuna-tang commented Jun 30, 2023

We need to add additional columns for dbt_utils.unique_combination_of_columns as we can run multiple keyword_id,ad_group_id and campaign_id for the same search_term_text & date_day.

Please provide your name and company
Name: Yuna Tang
Company: SafetyCulture

Link the issue/feature request which this PR is meant to address
#16

Detail what changes this PR introduces and how this addresses the issue/feature request linked above.
I have added additional columns in dbt_utils.unique_combination_of_columns test for apple_search_ads__search_term_report.
We can run multiple keyword_id,ad_group_id and campaign_id for the same search_term_text & date_day.
If we only include search_term_text & date_day, there will be duplications in the test.

How did you validate the changes introduced within this PR?
I have run below to validate there is duplication records with those combinations in our datawarehouse.

    select
        search_term_text, date_day,campaign_id,keyword_id,ad_group_id
    from "<your_test_db>"."apple_search_ads"."apple_search_ads__search_term_report"
    group by search_term_text, date_day,campaign_id,keyword_id,ad_group_id
    having count(*) > 1
    order by date_day desc;

Which warehouse did you use to develop these changes?
Redshift
Did you update the CHANGELOG?

  • [ x] Yes

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

  • Yes

Provide an emoji that best describes your current mood

😄

Feedback

We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.

PR Template

…lumns, we can run multiple keyword_id,ad_group_id and campaign_id for the same search_term_text & date_day
@yuna-tang yuna-tang marked this pull request as ready for review June 30, 2023 01:14
@fivetran-reneeli fivetran-reneeli changed the base branch from main to bugfix/unique_test_search_term_report July 3, 2023 15:31
@fivetran-reneeli fivetran-reneeli merged commit b7212c0 into fivetran:bugfix/unique_test_search_term_report Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants