bugfix: add additional columns for unique column combination test for apple_search_ads__search_term_report #17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to add additional columns for dbt_utils.unique_combination_of_columns as we can run multiple keyword_id,ad_group_id and campaign_id for the same search_term_text & date_day.
Please provide your name and company
Name: Yuna Tang
Company: SafetyCulture
Link the issue/feature request which this PR is meant to address
#16
Detail what changes this PR introduces and how this addresses the issue/feature request linked above.
I have added additional columns in dbt_utils.unique_combination_of_columns test for apple_search_ads__search_term_report.
We can run multiple keyword_id,ad_group_id and campaign_id for the same search_term_text & date_day.
If we only include search_term_text & date_day, there will be duplications in the test.
How did you validate the changes introduced within this PR?
I have run below to validate there is duplication records with those combinations in our datawarehouse.
Which warehouse did you use to develop these changes?
Redshift
Did you update the CHANGELOG?
Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)
Provide an emoji that best describes your current mood
😄
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.
PR Template
Community Pull Request Template (default)
Maintainer Pull Request Template (to be used by maintainers)