feat(lottie.component) performance improvement - first I added afterV… #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iewInit to where lottieContainer is used, added an input flag for runOutsideAngular so cd won't get triggred.
|
Thank you for your PR. I will look in to this when I get time 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Guys I really loved your wrapper to lottie (!!!) and was about to use it but since I'm required to highly think of performance before integrating anything I would really appreciate your feedback regarding the following PR, it will be great if you'll merge it, I didn't saw any contributing.md to this repro so I wan't sure you're allowing it but I had to try reaching out anyway :)
** I will probably upgrade to angular 8 as well on my fork, will be happy to open a new PR for you.
BR,
Liron!