Merge pull request #16 from fiverr/fix_null_refs_bug

fix new version null issues
fiverr · Aug 28, 2024 · 60d2271 · 60d2271
2 parents f01a704 + 6c90256
commit 60d2271
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/charts/karpenter_nodes/Chart.yaml b/charts/karpenter_nodes/Chart.yaml
@@ -1,6 +1,6 @@
 apiVersion: v2
 name: karpenter_nodes
-version: 1.1.1
+version: 1.1.2
 description: A Helm chart for generating NodeClasses and NodePools for Karpenter
 maintainers:
   - name: nadavbuc
diff --git a/charts/karpenter_nodes/templates/nodeclass.yaml b/charts/karpenter_nodes/templates/nodeclass.yaml
@@ -20,8 +20,8 @@ spec:
   {{- fail "nodeClass error: Either IamRole or IamInstanceProfile must be defined" }}
   {{- end }}
   amiFamily: {{ $v.amiFamily | default $.Values.amiFamily }}
-  amiSelectorTerms:
   {{- if or (hasKey $v "amiSelectorTerms") (hasKey $.Values "amiSelectorTerms") }}
+  amiSelectorTerms:
     {{- toYaml ($v.amiSelectorTerms | default $.Values.amiSelectorTerms) | nindent 4 }}
   {{- end }}
   subnetSelectorTerms:

diff --git a/charts/karpenter_nodes/templates/nodepool.yaml b/charts/karpenter_nodes/templates/nodepool.yaml
@@ -27,6 +27,8 @@ spec:
           {{- $v.nodeClassRef | toYaml | nindent 8 }}
         {{- else }}
         name: {{ $k }}-{{ $v.instances.architecture | default $.Values.instances.architecture }}
+        apiVersion: karpenter.sh/{{ $.Values.ApiVersion }}
+        kind: EC2NodeClass
         {{- end }}
       {{- if or (hasKey $v "taints") (eq ($v.autoTaint | default $.Values.autoTaint) "true") }}
       taints: