Add Mattermost subscriptions and fix a few things #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix a translation path. * Make component updates from incident trigger the normal event for component updates * Remove the `ShouldQueue` of `NewScheduleNotifications` to make it consistent with the others * Add a name to subscribers
|
@ElsaWeb thanks for this, i'll have a look through over the next few days. |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This is a pull request who adds a feature to have "mattermost" subscribers to be able to send updates to a mattermost endpoint.
This is a rather specific usage, but could potentially be useful for others, so we're submitting here.
We fixed and changed a few extra things to make it work, but we're not sure about all the changes.
We are not used at all with PHP/Laravel, so things may be wrongly designed, any feedback is welcome to improve it and make things better :)