Update notifications.php #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
French transation
|
@sedan07 here is a PR for you |
sedan07
approved these changes
Feb 6, 2021
There was a problem hiding this comment.
Hi @Yves911, Thanks for your PR, great to get the translations up to date. 😄
Just a minor tip for future: It can be quite useful to add a little bit of context to your commit messages to help others when they look through the commit history in future, maybe trying to debug or just discover how the code has changed over time to help their understanding. So in your case a message such as "French translation for notifications" would help give a little more information.
|
Sorry @Yves911 you already put the fact it was for French translation in your message, just not on the primary line... I need more coffee. |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
French translation