Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure link to manage notification subscriptions are signed #9 #17

Merged
merged 1 commit into from
Jan 28, 2021

Conversation

sedan07
Copy link

@sedan07 sedan07 commented Jan 28, 2021

Otherwise you get a lovely 403

@codecov-io
Copy link

codecov-io commented Jan 28, 2021

Codecov Report

Merging #17 (4b6559e) into 2.5 (219f016) will increase coverage by 1.97%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.5      #17      +/-   ##
============================================
+ Coverage     53.94%   55.92%   +1.97%     
  Complexity     1264     1264              
============================================
  Files           275      275              
  Lines          4799     4803       +4     
============================================
+ Hits           2589     2686      +97     
+ Misses         2210     2117      -93     
Impacted Files Coverage Δ Complexity Δ
...s/Component/ComponentStatusChangedNotification.php 40.81% <100.00%> (+1.23%) 8.00 <0.00> (ø)
...Notifications/Incident/NewIncidentNotification.php 47.50% <100.00%> (+37.24%) 7.00 <0.00> (ø)
...ons/IncidentUpdate/IncidentUpdatedNotification.php 46.93% <100.00%> (+38.60%) 7.00 <0.00> (ø)
...Notifications/Schedule/NewScheduleNotification.php 50.00% <100.00%> (+50.00%) 5.00 <0.00> (ø)
app/Integrations/Core/System.php 87.17% <0.00%> (+2.56%) 13.00% <0.00%> (ø%)
app/Presenters/SchedulePresenter.php 35.84% <0.00%> (+3.77%) 26.00% <0.00%> (ø%)
app/Presenters/IncidentUpdatePresenter.php 29.26% <0.00%> (+4.87%) 18.00% <0.00%> (ø%)
app/Presenters/ComponentPresenter.php 100.00% <0.00%> (+5.26%) 10.00% <0.00%> (ø%)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 219f016...4b6559e. Read the comment docs.

@sedan07 sedan07 merged commit 8bc8cc1 into 2.5 Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants