Don't use last component group id for "other" section on subscription page #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… page Otherwise this breaks then there aren't any component groups as it cannot use the last value the var was assigned as it never happened. #8
Codecov Report
@@ Coverage Diff @@
## 2.5 #16 +/- ##
============================================
+ Coverage 53.09% 54.03% +0.93%
Complexity 1264 1264
============================================
Files 275 275
Lines 4799 4799
============================================
+ Hits 2548 2593 +45
+ Misses 2251 2206 -45
Continue to review full report at Codecov.
|
graemedavidson
approved these changes
Jan 28, 2021
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise this breaks then there aren't any component groups as it
cannot use the last value the var was assigned as it never happened. #8