Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After component order change (dragging), ALL components tags fields are set to 1 #4

Closed
sedan07 opened this issue Jan 21, 2021 · 1 comment
Closed

After component order change (dragging), ALL components tags fields are set to 1 #4

sedan07 opened this issue Jan 21, 2021 · 1 comment
Assignees
@sedan07
Labels
bug Something isn't working
Milestone
2.5

Comments

@sedan07
Copy link

sedan07 commented Jan 21, 2021

After component order change (dragging) in the Admin panel ALL components have the same tags field set to 1.

Upstream: cachethq#3943
@sedan07 sedan07 added the bug Something isn't working label Jan 21, 2021
sedan07 added a commit that referenced this issue Jan 21, 2021
@sedan07
(#4) Don't overwrite tags with "1" when reordering components
947cd73
@sedan07 sedan07 self-assigned this Jan 21, 2021
@sedan07 sedan07 added this to the 2.5 milestone Jan 21, 2021
sedan07 added a commit that referenced this issue Jan 22, 2021
@sedan07
Merge pull request #5 from fiveai/4-component-order-breaking-tags
f16aaf7 
#4 component order breaking tags
@sedan07
Copy link
Author

sedan07 commented Jan 22, 2021

Fixed! Tags now preserved on re-ordering.

@sedan07 sedan07 closed this as completed Jan 22, 2021
sedan07 added a commit that referenced this issue Jan 28, 2021
@sedan07
(#4) Don't overwrite tags with "1" when reordering components
2ce88c2
@YannickFavre YannickFavre mentioned this issue Jun 22, 2021
Closed
@ghost ghost mentioned this issue Sep 30, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sedan07 sedan07

Labels
bug Something isn't working
Projects
None yet
Milestone
2.5
Development

No branches or pull requests
1 participant
@sedan07