Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify allocated_bytes does not include headers #183

Merged
merged 1 commit into from
Nov 10, 2022
Merged

Clarify allocated_bytes does not include headers #183

merged 1 commit into from
Nov 10, 2022

Conversation

stepancheg
Copy link
Contributor

No description provided.

konsumlamm
konsumlamm reviewed Nov 6, 2022
View reviewed changes
@stepancheg stepancheg force-pushed the allocated-bytes-no-headers branch from 1683ea4 to 4dc20fa Compare November 8, 2022 02:40
@stepancheg
Copy link
Contributor Author

Applied.

fitzgen
fitzgen approved these changes Nov 8, 2022
View reviewed changes
Copy link
Owner

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me with suggested wording tweak.

@stepancheg stepancheg force-pushed the allocated-bytes-no-headers branch from 4dc20fa to 1047262 Compare November 10, 2022 02:34
@stepancheg
Copy link
Contributor Author

Done.

@stepancheg stepancheg force-pushed the allocated-bytes-no-headers branch from 1047262 to 5805a29 Compare November 10, 2022 02:35
fitzgen
fitzgen approved these changes Nov 10, 2022
View reviewed changes
Copy link
Owner

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fitzgen fitzgen merged commit c699cd1 into fitzgen:main Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konsumlamm konsumlamm konsumlamm left review comments

@fitzgen fitzgen fitzgen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stepancheg @fitzgen @konsumlamm