Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent API response #179

Merged
merged 11 commits into from
Sep 25, 2023
Merged

Consistent API response #179

merged 11 commits into from
Sep 25, 2023

Conversation

fityannugroho
Copy link
Owner

@fityannugroho fityannugroho commented Sep 24, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Contributing Guidelines
  • Tests for the changes have been added (optional, for bug fixes or features)
  • Docs have been added / updated (optional, for bug fixes or features)

PR Type

What kind of change does this PR introduce?

  • Bug fix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes

What is the current behavior?

Issue Number: #178

What is the new behavior?

The API response is changed by including statusCode, message, and data properties.

Other information

This is a BREAKING CHANGES

@fityannugroho fityannugroho linked an issue Sep 24, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consistent response
1 participant