Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

note.php requires colgroup (issue #864) #867

Closed
wants to merge 1 commit into from
Closed

note.php requires colgroup (issue #864) #867

wants to merge 1 commit into from

Conversation

ddrury
Copy link
Contributor

@ddrury ddrury commented Mar 3, 2016

Also to handle partial dates, only check census year to find match in CensusAssistantModule function formatCensusNote

To handle partial dates, only check census year to find match in CensusAssistantModule function formatCensusNote
fisharebest added a commit that referenced this pull request Mar 25, 2016
@fisharebest
Copy link
Owner

There are two changes in one PR.

The first change (note.php) is fine.

The second change (afaict) introduces a bug, rather than fixes one?
Before the change, I see title="..." for the column headings. After the change, I don't.

So, I have extracted just the note.php changes. If you want to open a new issue for the other changes, please do.

@ddrury ddrury deleted the CensusDateMatch branch March 25, 2016 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants