Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Genealogical numbering system support #3297

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

divinity666
Copy link

Added support for the common genealogical numbering system of ancestors (ref. [https://en.wikipedia.org/wiki/Genealogical_numbering_systems]).

Numbering of individuals in the reports (especially the text reports) should be a common understandable system and not only an incrementing number system. This especially becomes obvious in trees where far away generations are no more filled with all ancestors. Anyway the numbering system proposed here also in this situation assures a reproducible numbering system if the same individual is tested.

@divinity666 divinity666 changed the title Genealogical numberbing system support Genealogical numbering system support May 24, 2020
@codecov
Copy link

codecov bot commented May 24, 2020

Codecov Report

Merging #3297 into master will increase coverage by 0.08%.
The diff coverage is 90.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3297      +/-   ##
============================================
+ Coverage     23.58%   23.67%   +0.08%     
- Complexity    11912    11916       +4     
============================================
  Files           862      862              
  Lines         41757    41772      +15     
============================================
+ Hits           9848     9888      +40     
+ Misses        31909    31884      -25     
Impacted Files Coverage Δ Complexity Δ
app/Report/ReportParserGenerate.php 72.07% <90.00%> (+0.15%) 527.00 <1.00> (+4.00)
app/Report/ReportPdfFootnote.php 87.87% <0.00%> (+40.90%) 19.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad1699c...fed3f73. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.09%) to 21.611% when pulling fed3f73 on divinity666:master into ad1699c on fisharebest:master.

Base automatically changed from master to main March 11, 2021 07:40
@arbor95
Copy link
Contributor

arbor95 commented Feb 14, 2024

This pull request is not implemented/accepted for more than 3 years and so I think it should be removed/closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants