Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Googlemaps module bug #929

Closed
ddrury opened this issue May 9, 2016 · 4 comments
Closed

Googlemaps module bug #929

ddrury opened this issue May 9, 2016 · 4 comments

Comments

@ddrury
Copy link
Contributor

ddrury commented May 9, 2016

With streetview enabled and setting the longitude for the centre of England as W1 which is returned as -1, when saving the streetview parameters something similar to the following error is generated (this one refers to sv_bearing but depending upon the edited values other fields can be in error)

\app\Statement.php:82 SQLSTATE[01000]: Warning: 1265 Data truncated for column 'sv_bearing' at row 1 #0 \app\Statement.php:82 PDOException("SQLSTATE[01000]: Warning: 1265 Data truncated for column 'sv_bearing' at row 1") #1 \app\Module\GoogleMapsModule.php:3282 execute([array]) #2 \app\Module\GoogleMapsModule.php:108 placesEdit() #3 \module.php:26 modAction('places_edit')

@ddrury ddrury closed this as completed May 9, 2016
@ddrury ddrury reopened this May 9, 2016
@fisharebest
Copy link
Owner

As per your earlier comment, the slice(0,-1) look bogus, and I don't know why they were added.

@ddrury
Copy link
Contributor Author

ddrury commented May 9, 2016

Thanks for this, I removed the comment because the slice(0, -1) looked
so flaky that I thought there must be something devious going on!

Regards
David
Please consider the environment before printing this e-mail

------ Original Message ------
From: "Greg Roach" [email protected]
To: "fisharebest/webtrees" [email protected]
Cc: "David Drury" [email protected]; "State change"
[email protected]
Sent: 09/05/2016 21:30:58
Subject: Re: [fisharebest/webtrees] Googlemaps module bug (#929)

As per your earlier comment, the slice(0,-1) look bogus, and I don't
know why they were added.


You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub

@fisharebest
Copy link
Owner

Maybe at one time there were degree signs at the end of the lat/long which needed removing?

@ddrury
Copy link
Contributor Author

ddrury commented May 10, 2016

Yeah - good idea.

BTW I've noticed we're not up to date with the latest maps api (the
latest seems to require a key again) and I get lots of 404 errors on
loading a map - don't know if they're related.

When I get some time I'll have a look if you like.

Regards
David
Please consider the environment before printing this e-mail

------ Original Message ------
From: "Greg Roach" [email protected]
To: "fisharebest/webtrees" [email protected]
Cc: "David Drury" [email protected]; "State change"
[email protected]
Sent: 10/05/2016 08:58:52
Subject: Re: [fisharebest/webtrees] Googlemaps module bug (#929)

Maybe at one time there were degree signs at the end of the lat/long
which needed removing?


You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants