Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No update form the field updated in tab wt_news #5068

Closed
luenissla opened this issue Dec 4, 2024 · 5 comments
Closed

No update form the field updated in tab wt_news #5068

luenissla opened this issue Dec 4, 2024 · 5 comments

Comments

@luenissla
Copy link

In the news box (table wt_news), the date of the change (updated) is not updated when a change is made. The old date remains. (In the example for the issue, I changed the date manually in the database).
Update_News_Zwischenablage_12-04-2024_02

@fisharebest
Copy link
Owner

See #3208

I guess this needs a checkbox or similar...

@fisharebest
Copy link
Owner

Or maybe we should allow the user to edit the date/time?

@luenissla
Copy link
Author

Hello Greg,
I don't think that should be necessary ;-)
It might be possible to have the option to click whether the date should be updated or not, as is possible with changes in Webtrees.
I just noticed that the variable, which is called “updated”, is obviously only entered the first time it is written.
If you want to document the date after updating the program, it seems awkward if the date is still 2008. ;-)

@fisharebest
Copy link
Owner

Screenshot 2024-12-09 at 09 36 44

You can now

  • keep the existing timestamp
  • edit the existing timestam
  • use the current date/time

@mpwt
Copy link
Contributor

mpwt commented Dec 20, 2024

Please test the changes in v2.2.2-dev (login as moderator, add Journal to My Page and add a new entry). You will receive an error message when saving a new journal or news entry.

Object of class Fisharebest\Webtrees\Timestamp could not be converted to string …/vendor/illuminate/database/Connection.php:719
#0 …/vendor/illuminate/database/Connection.php(719): PDOStatement->bindValue()
#1 …/vendor/illuminate/database/MySqlConnection.php(49): Illuminate\Database\Connection->bindValues()
#2 …/vendor/illuminate/database/Connection.php(812): Illuminate\Database\MySqlConnection->{closure:Illuminate\Database\MySqlConnection::insert():42}()
#3 …/vendor/illuminate/database/Connection.php(779): Illuminate\Database\Connection->runQueryCallback()
#4 …/vendor/illuminate/database/MySqlConnection.php(42): Illuminate\Database\Connection->run()
#5 …/vendor/illuminate/database/Query/Builder.php(3748): Illuminate\Database\MySqlConnection->insert()
#6 …/app/Module/UserJournalModule.php(203): Illuminate\Database\Query\Builder->insert()
#7 …/app/Http/RequestHandlers/ModuleAction.php(85): Fisharebest\Webtrees\Module\UserJournalModule->postEditJournalAction()
#8 …/app/Http/Middleware/RequestHandler.php(52): Fisharebest\Webtrees\Http\RequestHandlers\ModuleAction->handle()
#9 …/app/Http/Dispatcher.php(76): Fisharebest\Webtrees\Http\Middleware\RequestHandler->process()
#10 …/app/Module/HitCountFooterModule.php(149): Psr\Http\Server\RequestHandlerInterface@anonymous->handle()
#11 …/app/Http/Dispatcher.php(76): Fisharebest\Webtrees\Module\HitCountFooterModule->process()
#12 …/app/Module/CheckForNewVersion.php(117): Psr\Http\Server\RequestHandlerInterface@anonymous->handle()
#13 …/app/Http/Dispatcher.php(76): Fisharebest\Webtrees\Module\CheckForNewVersion->process()
#14 …/app/Http/Middleware/CheckCsrf.php(80): Psr\Http\Server\RequestHandlerInterface@anonymous->handle()
#15 …/app/Http/Dispatcher.php(76): Fisharebest\Webtrees\Http\Middleware\CheckCsrf->process()
#16 …/app/Http/Dispatcher.php(47): Psr\Http\Server\RequestHandlerInterface@anonymous->handle()
#17 …/app/Http/Middleware/Router.php(136): Fisharebest\Webtrees\Http\Dispatcher::dispatch()
#18 …/app/Http/Dispatcher.php(76): Fisharebest\Webtrees\Http\Middleware\Router->process()
#19 …/app/Http/Middleware/BootModules.php(58): Psr\Http\Server\RequestHandlerInterface@anonymous->handle()
#20 …/app/Http/Dispatcher.php(76): Fisharebest\Webtrees\Http\Middleware\BootModules->process()
#21 …/app/Http/Middleware/RegisterGedcomTags.php(54): Psr\Http\Server\RequestHandlerInterface@anonymous->handle()
#22 …/app/Http/Dispatcher.php(76): Fisharebest\Webtrees\Http\Middleware\RegisterGedcomTags->process()
#23 …/app/Http/Middleware/LoadRoutes.php(75): Psr\Http\Server\RequestHandlerInterface@anonymous->handle()
#24 …/app/Http/Dispatcher.php(76): Fisharebest\Webtrees\Http\Middleware\LoadRoutes->process()
#25 …/app/Http/Middleware/CheckForNewVersion.php(57): Psr\Http\Server\RequestHandlerInterface@anonymous->handle()
#26 …/app/Http/Dispatcher.php(76): Fisharebest\Webtrees\Http\Middleware\CheckForNewVersion->process()
#27 …/app/Http/Middleware/UseTransaction.php(45): Psr\Http\Server\RequestHandlerInterface@anonymous->handle()
#28 …/vendor/illuminate/database/Concerns/ManagesTransactions.php(32): Fisharebest\Webtrees\Http\Middleware\UseTransaction::{closure:Fisharebest\Webtrees\Http\Middleware\UseTransaction::process():44}()
#29 …/app/Http/Middleware/UseTransaction.php(44): Illuminate\Database\Connection->transaction()
#30 …/app/Http/Dispatcher.php(76): Fisharebest\Webtrees\Http\Middleware\UseTransaction->process()
#31 …/app/Http/Middleware/DoHousekeeping.php(71): Psr\Http\Server\RequestHandlerInterface@anonymous->handle()
#32 …/app/Http/Dispatcher.php(76): Fisharebest\Webtrees\Http\Middleware\DoHousekeeping->process()
#33 …/app/Http/Middleware/UseTheme.php(66): Psr\Http\Server\RequestHandlerInterface@anonymous->handle()
#34 …/app/Http/Dispatcher.php(76): Fisharebest\Webtrees\Http\Middleware\UseTheme->process()
#35 …/app/Http/Middleware/CheckForMaintenanceMode.php(51): Psr\Http\Server\RequestHandlerInterface@anonymous->handle()
#36 …/app/Http/Dispatcher.php(76): Fisharebest\Webtrees\Http\Middleware\CheckForMaintenanceMode->process()
#37 …/app/Http/Middleware/UseLanguage.php(69): Psr\Http\Server\RequestHandlerInterface@anonymous->handle()
#38 …/app/Http/Dispatcher.php(76): Fisharebest\Webtrees\Http\Middleware\UseLanguage->process()
#39 …/app/Http/Middleware/UseSession.php(79): Psr\Http\Server\RequestHandlerInterface@anonymous->handle()
#40 …/app/Http/Dispatcher.php(76): Fisharebest\Webtrees\Http\Middleware\UseSession->process()
#41 …/app/Http/Middleware/UpdateDatabaseSchema.php(57): Psr\Http\Server\RequestHandlerInterface@anonymous->handle()
#42 …/app/Http/Dispatcher.php(76): Fisharebest\Webtrees\Http\Middleware\UpdateDatabaseSchema->process()
#43 …/app/Http/Middleware/UseDatabase.php(60): Psr\Http\Server\RequestHandlerInterface@anonymous->handle()
#44 …/app/Http/Dispatcher.php(76): Fisharebest\Webtrees\Http\Middleware\UseDatabase->process()
#45 …/app/Http/Middleware/BadBotBlocker.php(309): Psr\Http\Server\RequestHandlerInterface@anonymous->handle()
#46 …/app/Http/Dispatcher.php(76): Fisharebest\Webtrees\Http\Middleware\BadBotBlocker->process()
#47 …/app/Http/Middleware/CompressResponse.php(71): Psr\Http\Server\RequestHandlerInterface@anonymous->handle()
#48 …/app/Http/Dispatcher.php(76): Fisharebest\Webtrees\Http\Middleware\CompressResponse->process()
#49 …/app/Http/Middleware/ContentLength.php(40): Psr\Http\Server\RequestHandlerInterface@anonymous->handle()
#50 …/app/Http/Dispatcher.php(76): Fisharebest\Webtrees\Http\Middleware\ContentLength->process()
#51 …/vendor/middlewares/client-ip/src/ClientIp.php(65): Psr\Http\Server\RequestHandlerInterface@anonymous->handle()
#52 …/app/Http/Middleware/ClientIp.php(47): Middlewares\ClientIp->process()
#53 …/app/Http/Dispatcher.php(76): Fisharebest\Webtrees\Http\Middleware\ClientIp->process()
#54 …/app/Http/Middleware/PublicFiles.php(62): Psr\Http\Server\RequestHandlerInterface@anonymous->handle()
#55 …/app/Http/Dispatcher.php(76): Fisharebest\Webtrees\Http\Middleware\PublicFiles->process()
#56 …/app/Http/Middleware/HandleExceptions.php(89): Psr\Http\Server\RequestHandlerInterface@anonymous->handle()
#57 …/app/Http/Dispatcher.php(76): Fisharebest\Webtrees\Http\Middleware\HandleExceptions->process()
#58 …/app/Http/Middleware/SecurityHeaders.php(49): Psr\Http\Server\RequestHandlerInterface@anonymous->handle()
#59 …/app/Http/Dispatcher.php(76): Fisharebest\Webtrees\Http\Middleware\SecurityHeaders->process()
#60 …/app/Http/Middleware/BaseUrl.php(73): Psr\Http\Server\RequestHandlerInterface@anonymous->handle()
#61 …/app/Http/Dispatcher.php(76): Fisharebest\Webtrees\Http\Middleware\BaseUrl->process()
#62 …/app/Http/Middleware/ReadConfigIni.php(68): Psr\Http\Server\RequestHandlerInterface@anonymous->handle()
#63 …/app/Http/Dispatcher.php(76): Fisharebest\Webtrees\Http\Middleware\ReadConfigIni->process()
#64 …/app/Http/Middleware/EmitResponse.php(57): Psr\Http\Server\RequestHandlerInterface@anonymous->handle()
#65 …/app/Http/Dispatcher.php(76): Fisharebest\Webtrees\Http\Middleware\EmitResponse->process()
#66 …/app/Http/Middleware/ErrorHandler.php(38): Psr\Http\Server\RequestHandlerInterface@anonymous->handle()
#67 …/app/Http/Dispatcher.php(76): Fisharebest\Webtrees\Http\Middleware\ErrorHandler->process()
#68 …/app/Http/Dispatcher.php(47): Psr\Http\Server\RequestHandlerInterface@anonymous->handle()
#69 …/app/Webtrees.php(276): Fisharebest\Webtrees\Http\Dispatcher::dispatch()
#70 …/app/Webtrees.php(249): Fisharebest\Webtrees\Webtrees->httpRequest()
#71 …/index.php(24): Fisharebest\Webtrees\Webtrees->run()
#72 {main}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants