Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slovak alphabet #4476

Closed
fisharebest opened this issue Jun 11, 2022 · 2 comments
Closed

Slovak alphabet #4476

fisharebest opened this issue Jun 11, 2022 · 2 comments

Comments

@fisharebest
Copy link
Owner

The Slovak alphabet is missing some letters with diacritics and double-letters

https://github.com/fisharebest/webtrees/blob/2.1.5/app/Services/LocalizationService.php#L53

https://en.wikipedia.org/wiki/Slovak_orthography

@ro-la
Copy link
Contributor

ro-la commented Jun 20, 2022

@fisharebest
The fix 65993c2 is not correct

Not "ĎZ", but "DŽ", and similar to Czech it should be a "CH" after "H"

Line 53 should be:
private const SLOVAKIAN_ALPHABET = ['A', 'Á', 'Ä', 'B', 'C', 'Č', 'D', 'Ď', 'DZ', 'DŽ', 'E', 'É', 'F', 'G', 'H', 'CH', 'I', 'Í', 'J', 'K', 'L', 'Ľ', 'Ĺ', 'M', 'N', 'Ň', 'O', 'Ó', 'Ô', 'P', 'Q', 'R', 'Ŕ', 'S', 'Š', 'T', 'Ť', 'U', 'Ú', 'V', 'W', 'X', 'Y', 'Ý', 'Z', 'Ž'];

And in the private const DIGRAPHS (lines 90-96) should be added following line:
'sk' => ['DZ' => 'DZ', 'DŽ' => 'DŽ','CH' => 'CH'],

fisharebest added a commit that referenced this issue Jun 20, 2022
@fisharebest
Copy link
Owner Author

Thanks for the correction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants