Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid storing unnecessary values in the database #143

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

fredden
Copy link
Contributor

@fredden fredden commented Oct 12, 2023

While investigating an issue, I noticed that there are no "use default" tick-boxes in the admin for configuration settings from this module. This means that whenever the configuration page is saved, all values are stored in the database - even when they match the default defined in this module.

@sprankhub sprankhub merged commit e4cb43f into firegento:develop Oct 12, 2023
@sprankhub
Copy link
Member

Thanks, @fredden!

@fredden fredden deleted the canRestore branch October 12, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants