Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.1 - Fix optional parameter error #122

Conversation

VincentMarmiesse
Copy link
Contributor

With PHP 8.1, fix the following error

Deprecated Functionality: Optional parameter $delimiter declared before required parameter $string is implicitly treated as a required parameter in /var/www/html/vendor/firegento/fastsimpleimport/Model/Import/Category.php on line 106

That's because $delimiter can't be optional if the following parameter $string is not.

@sprankhub
Copy link
Member

Thanks a lot, @VincentMarmiesse! This has actually already been tackled in #121, which merges the changes into the bigger refactoring #120. So I tend to wait for the merge there. Do you agree, @avstudnitz?

@VincentMarmiesse
Copy link
Contributor Author

Hi @sprankhub !
Thanks for your answer, do you have any ETA on this?

@sprankhub
Copy link
Member

That pretty much depends on @avstudnitz. I think it is his turn :)

@iwanvanzijderveld
Copy link

Is there any news on when this will be released?

@sprankhub
Copy link
Member

@avstudnitz, could you give an update here? You invested so much time already, let us finish it together! Happy to review / help with it...

@linshin
Copy link

linshin commented Aug 31, 2022

Any updates here?

@avstudnitz
Copy link
Member

Sorry, somehow I missed this comversation. I updated the PR and, yes, that issue is tackled in the 2.0 refactoring as well.

@avstudnitz avstudnitz closed this Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants