Skip to content

Moving meshes final #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 37 commits into
base: main
Choose a base branch
from
Draft

Moving meshes final #431

wants to merge 37 commits into from

Conversation

@jshipton
Copy link
Contributor

@jshipton jshipton commented Aug 24, 2023

No description provided.

@jshipton
first attempt at mesh movement timeloop
0789602
@jshipton
progress: moving mesh Galewsky script runs and produces an adapted in…
a9f390a 
…itial mesh
@jshipton
Progress: runs but is blowing up. Much tidying needed
f215579
@jshipton
oops, forgot these files
e314d47
@jshipton
hack circulation form a bit for now
f8e282d
@jshipton
oops, I forgot that the vector_invariant_form already included a grad…
756be5e 
…(usq) term
@jshipton
fix minus sign
d90fb4d
@jshipton
a couple of hard coded constant_jacobian=False args
5f49d46
@jshipton
Merge branch 'main' of https://github.com/firedrakeproject/gusto into…
b85f770 
… moving_meshes_final
@jshipton
these LVPs need constant_Jacobian=False
905e417
@jshipton
some fixes to setup script
0d38a79
@jshipton
IT WORKS!
54b1f05
@jshipton
remove debugging prints from timeloop
34305f0
@jshipton
remove another debugging print
782ade1
@jshipton
tidy code and fix memory issues
164c31a
@jshipton
enable adapting to field
04569b0
@jshipton
put some info in the directory name
8394235
@jshipton
remove factor of a half
4ce1683
@jshipton
refactor mesh movement timeloop so that the new mesh is only computed…
71bcb2a 
… once and the transport step on the old mesh is done outside of the iteration
@jshipton
Merge branch 'main' of https://github.com/firedrakeproject/gusto into…
166d2b2 
… moving_meshes_final
@jshipton
fix import error related to merge
cd0232f
@jshipton
fix some lint
af283f9
@jshipton
tiny lint fix
f9ee380
@jshipton
get perp from the right place - not sure how this works on main!
e2451b1
@jshipton
removing hack to set up diagnostics earlier as this breaks tests
5f5b6a1
@jshipton
I think this fixes the tests but might break mesh movement - check si…
2c36527 
…gn of ke term!!
@jshipton
more lint fixing
40e9116
@jshipton
more fixes for merge with main
389bde7
@jshipton
I think this works with the new definition of the transport forms
dc238c8
@jshipton
make solver non-convergence warning go to logger
809ceed
@tommbendall tommbendall added enhancement Involves adding a new capability research problem Involves new science, with possibly unknown outcome labels Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement Involves adding a new capability research problem Involves new science, with possibly unknown outcome

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jshipton @tommbendall