flamenco, vm: add bpf loader serialization test fixtures#7459
Merged
topointon-jump merged 1 commit intomainfrom Jan 16, 2026
Merged
flamenco, vm: add bpf loader serialization test fixtures#7459topointon-jump merged 1 commit intomainfrom
topointon-jump merged 1 commit intomainfrom
Conversation
2 tasks
topointon-jump
force-pushed
the
topointon/bpf-loader-serialization-testss
branch
from
3d25c88 to
3aa95f5
Compare
cmoyes-jump
reviewed
Nov 28, 2025
topointon-jump
force-pushed
the
topointon/bpf-loader-serialization-testss
branch
2 times, most recently
from
a15b3ff to
9a7e90d
Compare
topointon-jump
commented
Nov 28, 2025
Comment on lines
412
to
416
| if( FD_UNLIKELY( err ) ) { | ||
| return err; | ||
| } | ||
|
|
||
| if( FD_UNLIKELY( input==NULL ) ) { | ||
| return FD_EXECUTOR_INSTR_ERR_MISSING_ACC; | ||
| } | ||
|
|
||
| fd_sha256_t _sha[1]; |
Contributor
Author
There was a problem hiding this comment.
fd_exec_instr_ctx_get_index_of_instr_account_in_transaction throws FD_EXECUTOR_INSTR_ERR_MISSING_ACC if the account is missing, so propagating the error is the correct thing to do here and doesn't change the behaviour.
Performance Measurements ⏳
|
Performance Measurements ⏳
|
Performance Measurements ⏳
|
mjain-jump
reviewed
Nov 28, 2025
topointon-jump
force-pushed
the
topointon/bpf-loader-serialization-testss
branch
5 times, most recently
from
85c1a5f to
fee122a
Compare
Performance Measurements ⏳
|
topointon-jump
changed the title
topointon-jump
force-pushed
the
topointon/bpf-loader-serialization-testss
branch
from
fee122a to
1bae3dd
Compare
cmoyes-jump
previously approved these changes
Jan 16, 2026
Performance Measurements ⏳
|
topointon-jump
force-pushed
the
topointon/bpf-loader-serialization-testss
branch
from
1bae3dd to
90314c6
Compare
cmoyes-jump
approved these changes
Jan 16, 2026
Performance Measurements ⏳
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a set of fixtures and a unit test fixture runner for vm input serialization, generated by running the input through the Agave vm input serializers. Compares the output buffer, the vm regions and the region metadata. Includes coverage of
stricter_abi_and_runtime_constraintsandaccount_data_direct_mapping.Also tests the
provide_instruction_data_offset_in_vm_r2feature gate.Adjusted some of the serialization code to make it more amenable for unit testing.