refactor(firedancer): create and document explicit watermark fseqs #3946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidatong
force-pushed
the
chali/fix/fts
branch
from
dc58038 to
f78a429
Compare
lidatong
changed the title
lidatong
force-pushed
the
chali/fix/fts
branch
from
f78a429 to
97d8521
Compare
lidatong
force-pushed
the
chali/fix/fts
branch
from
97d8521 to
2dc2068
Compare
mmcgee-jump
reviewed
Feb 4, 2025
| fd_topob_tile_uses( topo, replay_tile, finalized_obj, FD_SHMEM_JOIN_MODE_READ_WRITE ); | ||
| FD_TEST( fd_pod_insertf_ulong( topo->props, finalized_obj->id, "finalized" ) ); | ||
|
|
||
| /* published - this is the minimum of Firedancer's local tower root |
There was a problem hiding this comment.
This shared state concurrency through fseqs is extremely suspicious and seems quite bug prone. Why not have the tiles pass messages via. the regular mcaches?
There was a problem hiding this comment.
whats the concern / why bug-prone? seems to me to require a lot less code than mcache message passing and seems simpler to leverage that these are all ulongs. anyone that wants to read these watermarks just joins the fseqs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.