runtime: move stake and move lamports instructions#2487
Merged
kbhargava-jump merged 1 commit intomainfrom Jul 31, 2024
Merged
Conversation
kbhargava-jump
force-pushed
the
move-stake-lamport-ixns
branch
12 times, most recently
from
7b39103 to
7d664dc
Compare
kbhargava-jump
force-pushed
the
move-stake-lamport-ixns
branch
2 times, most recently
from
7d664dc to
076073e
Compare
kbhargava-jump
commented
Jul 30, 2024
kbhargava-jump
force-pushed
the
move-stake-lamport-ixns
branch
from
1400fe2 to
ff36237
Compare
Contributor
ibhatt-jumptrading
left a comment
ibhatt-jumptrading
left a comment
There was a problem hiding this comment.
lgtm just nits + small things
kbhargava-jump
force-pushed
the
move-stake-lamport-ixns
branch
6 times, most recently
from
261de33 to
6164e50
Compare
topointon-jump
previously approved these changes
Jul 31, 2024
| // ----------------------- ONLY CHANGE BELOW THIS LINE ----------------------- | ||
| ledgers::bpf_loader_ledger(&rpc_client, &arc_client, &payer, &program_data, &account_data); | ||
| // ledgers::bpf_loader_ledger(&rpc_client, &arc_client, &payer, &program_data, &account_data); | ||
| ledgers::stake_ledger(&rpc_client, &payer); |
Contributor
There was a problem hiding this comment.
Instead of changing this every time on a one-off basis, we should have a deterministic script we can run to generate all the test ledgers. Then we can just add to this in PRs. I think this file is basically that with some tweaks.
jumpsiegel
previously approved these changes
Jul 31, 2024
kbhargava-jump
force-pushed
the
move-stake-lamport-ixns
branch
from
6164e50 to
5c59872
Compare
topointon-jump
approved these changes
Jul 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
agave has added two new stake instructions: anza-xyz/agave#1928