Skip to content

Update rust and libseccomp dependencies#6029

Merged
zulinx86 merged 5 commits into
firecracker-microvm:mainfrom
zulinx86:20260710-1316-update-rust-and-libseccomp-dependencies
Jul 15, 2026
Merged

Update rust and libseccomp dependencies#6029
zulinx86 merged 5 commits into
firecracker-microvm:mainfrom
zulinx86:20260710-1316-update-rust-and-libseccomp-dependencies

Conversation

@zulinx86

@zulinx86 zulinx86 commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Changes

  • Update libseccomp from v2.6.0 to v2.6.1 in the development container.
  • Update the Rust toolchain from 1.96.0 to 1.97.0.
  • Fix the Clippy warnings introduced by Rust 1.97.0.
  • Update the default development container image from v91 to v92.
  • Suppress rustup informational logs when the cargo-deny A/B test installs the baseline toolchain on demand.

Reason

Closes #6012
Closes #6027

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • I have read and understand CONTRIBUTING.md.
  • I have run tools/devtool checkbuild --all to verify that the PR passes
    build checks on all supported architectures.
  • I have run tools/devtool checkstyle to verify that the PR passes the
    automated style checks.
  • I have described what is done in these changes, why they are needed, and
    how they are solving the problem in a clear and encompassing way.
  • [na] I have updated any relevant documentation (both in code and in the docs)
    in the PR.
  • [na] I have mentioned all user-facing changes in CHANGELOG.md.
  • If a specific issue led to this PR, this PR closes the issue.
  • [na] When making API changes, I have followed the
    Runbook for Firecracker API changes.
  • I have tested all new and changed functionalities in unit tests and/or
    integration tests.
  • [na] I have linked an issue to every new TODO.

  • This functionality cannot be added in rust-vmm.

zulinx86 added 2 commits July 14, 2026 11:21
libseccomp v2.6.1 [1] includes several security fixes. Firecracker's
runtime and bundled default filters are not affected by any of the
addressed issues because runtime loads precompiled BPF filters and the
default policies do not meet their trigger conditions.

Update the dev container dependency to incorporate the fixes and
harden seccompiler-bin when compiling unusually large custom profiles.

[1]: https://github.com/seccomp/libseccomp/releases/tag/v2.6.1

Signed-off-by: Takahiro Itazuri <zulinx86@gmail.com>
Rust 1.97.0 [1] does not announce a CVE or security advisory. It
does fix an unsound coercion in the `pin!` macro [2][3] that can
let safe Rust code trigger undefined behavior.

Firecracker's source does not use the affected `pin!` macro, so
this issue does not affect Firecracker.

Update the repository toolchain pin and development container to
this release.

[1]: https://github.com/rust-lang/rust/releases/tag/1.97.0
[2]: rust-lang/rust#153438
[3]: rust-lang/rust#153457

Signed-off-by: Takahiro Itazuri <zulinx86@gmail.com>
@zulinx86
zulinx86 force-pushed the 20260710-1316-update-rust-and-libseccomp-dependencies branch 3 times, most recently from 7f4273d to 5762667 Compare July 14, 2026 12:11
@codecov

codecov Bot commented Jul 14, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 82.82%. Comparing base (1faca2f) to head (8c0eaec).

Files with missing lines Patch % Lines
src/jailer/src/cgroup.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6029   +/-   ##
=======================================
  Coverage   82.82%   82.82%           
=======================================
  Files         277      277           
  Lines       30444    30444           
=======================================
  Hits        25216    25216           
  Misses       5228     5228           
Flag Coverage Δ
5.10-m5n.metal 83.09% <50.00%> (+<0.01%) ⬆️
5.10-m6a.metal 82.43% <50.00%> (-0.01%) ⬇️
5.10-m6g.metal 79.84% <66.66%> (ø)
5.10-m6i.metal 83.09% <50.00%> (-0.01%) ⬇️
5.10-m7a.metal-48xl 82.42% <50.00%> (ø)
5.10-m7g.metal 79.84% <66.66%> (ø)
5.10-m7i.metal-24xl 83.06% <50.00%> (-0.01%) ⬇️
5.10-m7i.metal-48xl 83.06% <50.00%> (-0.02%) ⬇️
5.10-m8g.metal-24xl 79.84% <66.66%> (ø)
5.10-m8g.metal-48xl 79.84% <66.66%> (-0.01%) ⬇️
5.10-m8i.metal-48xl 83.06% <50.00%> (-0.01%) ⬇️
5.10-m8i.metal-96xl 83.06% <50.00%> (ø)
6.1-m5n.metal 83.11% <50.00%> (-0.01%) ⬇️
6.1-m6a.metal 82.46% <50.00%> (ø)
6.1-m6g.metal 79.84% <66.66%> (-0.01%) ⬇️
6.1-m6i.metal 83.11% <50.00%> (ø)
6.1-m7a.metal-48xl 82.45% <50.00%> (-0.01%) ⬇️
6.1-m7g.metal 79.84% <66.66%> (-0.01%) ⬇️
6.1-m7i.metal-24xl 83.12% <50.00%> (-0.01%) ⬇️
6.1-m7i.metal-48xl 83.13% <50.00%> (ø)
6.1-m8g.metal-24xl 79.84% <66.66%> (-0.01%) ⬇️
6.1-m8g.metal-48xl 79.84% <66.66%> (-0.01%) ⬇️
6.1-m8i.metal-48xl 83.13% <50.00%> (-0.01%) ⬇️
6.1-m8i.metal-96xl 83.13% <50.00%> (ø)
6.18-m5n.metal 83.12% <50.00%> (ø)
6.18-m6a.metal 82.46% <50.00%> (ø)
6.18-m6g.metal 79.84% <66.66%> (-0.01%) ⬇️
6.18-m6i.metal 83.11% <50.00%> (-0.01%) ⬇️
6.18-m7a.metal-48xl 82.45% <50.00%> (ø)
6.18-m7g.metal 79.83% <66.66%> (-0.01%) ⬇️
6.18-m7i.metal-24xl 83.12% <50.00%> (-0.02%) ⬇️
6.18-m7i.metal-48xl 83.12% <50.00%> (-0.02%) ⬇️
6.18-m8g.metal-24xl 79.83% <66.66%> (-0.01%) ⬇️
6.18-m8g.metal-48xl 79.84% <66.66%> (-0.01%) ⬇️
6.18-m8i.metal-48xl 83.13% <50.00%> (-0.01%) ⬇️
6.18-m8i.metal-96xl 83.13% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zulinx86
zulinx86 force-pushed the 20260710-1316-update-rust-and-libseccomp-dependencies branch from 5762667 to 1030128 Compare July 14, 2026 12:21
zulinx86 added 2 commits July 14, 2026 12:23
Rust 1.97.0's Clippy reports redundant references passed to
`format!` and direct map iteration when only the values are used.

Remove the redundant formatting references in the cgroup and jailer
code, and iterate over the MMIO device map with `HashMap::values`.
These are lint-only changes and do not alter runtime behavior.

Signed-off-by: Takahiro Itazuri <zulinx86@gmail.com>
The new devctr image contains Rust 1.97.0 and libseccomp v2.6.1.

Signed-off-by: Takahiro Itazuri <zulinx86@gmail.com>
@zulinx86
zulinx86 force-pushed the 20260710-1316-update-rust-and-libseccomp-dependencies branch from 1030128 to d858077 Compare July 14, 2026 12:23
When a Rust toolchain update is tested, the devctr contains the new
toolchain but not the old toolchain required by the A (before) checkout.
Running cargo in that checkout invokes the rustup proxy, which installs
the old toolchain before starting Cargo and writes informational lines
to cargo-deny's stderr, for example:

    info: syncing channel updates for 1.96.0-x86_64-unknown-linux-gnu
    info: downloading 5 components

The audit test parses each stderr line as JSON, so these lines cause a
JSONDecodeError before the A and B results can be compared.

Set RUSTUP_LOG=warn only for cargo deny. This suppresses rustup info
output while preserving warnings and errors, and keeps the JSON parser
strict.

Signed-off-by: Takahiro Itazuri <zulinx86@gmail.com>
@zulinx86
zulinx86 force-pushed the 20260710-1316-update-rust-and-libseccomp-dependencies branch from 9caa2ff to 8c0eaec Compare July 14, 2026 13:00
@zulinx86 zulinx86 added the Status: Awaiting review Indicates that a pull request is ready to be reviewed label Jul 14, 2026
@zulinx86
zulinx86 enabled auto-merge July 14, 2026 13:45
@zulinx86
zulinx86 added this pull request to the merge queue Jul 15, 2026
Merged via the queue into firecracker-microvm:main with commit 295f547 Jul 15, 2026
7 of 8 checks passed
@zulinx86
zulinx86 deleted the 20260710-1316-update-rust-and-libseccomp-dependencies branch July 15, 2026 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Awaiting review Indicates that a pull request is ready to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(deps): update libseccomp to v2.6.1

3 participants