Add VIRTIO_NET_F_MRG_RXBUF to virtio-net #4658
Draft
+278
−128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShadowCurse
force-pushed
the
net_mrg_buf
branch
5 times, most recently
from
b200d76
to
ccda0b0
Compare
ShadowCurse
force-pushed
the
net_mrg_buf
branch
5 times, most recently
from
cb47e17
to
cdc6f02
Compare
Add yet another function to convert numbers Signed-off-by: Egor Lazarchuk <[email protected]>
Add info about queue len and actual size to the message. Signed-off-by: Egor Lazarchuk <[email protected]>
There is no point of notifing guest if there are no fully processed packets. Signed-off-by: Egor Lazarchuk <[email protected]>
Usize to u64 is safe as Firecracker only supports 64bit platforms where usize == u64. Signed-off-by: Egor Lazarchuk <[email protected]>
Replace offset calculations with hard coded values with more descriptive `std::mem::sizeof` with better comments of why the offset should be calculated this way. Additionally replace setting used element fields one by one with single call to `write_obj`. Signed-off-by: Egor Lazarchuk <[email protected]>
Used `std::mem::size_of` to calculate offset instead of hard coded values. Signed-off-by: Egor Lazarchuk <[email protected]>
Update methods that set values in the `used_ring` to be more descriptive and coherent. Signed-off-by: Egor Lazarchuk <[email protected]>
Now virtio-net device can split incoming packets across multiple descriptor chains if VIRTIO_NET_F_MRG_RXBUF is enabled by the guest. Signed-off-by: Egor Lazarchuk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add VIRTIO_NET_F_MRG_RXBUF to virtio-net
fixes: #1314
Reason
Better performance and guest memory utilization.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
PR.
CHANGELOG.md.TODOs link to an issue.contribution quality standards.
rust-vmm.