Todo #3636
Closed
Todo #3636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roypat
previously requested changes
May 30, 2023
.github/pull_request_template.md
Outdated
There was a problem hiding this comment.
Mhh, it looks like you put the pull request description into the template file, instead of just filing it out on GitHub 🤔 Could you drop this file from your PR, please?
src/logger/src/metrics.rs
Outdated
| @@ -87,18 +87,16 @@ pub struct Metrics<T: Serialize> { | |||
| // Metrics will get flushed here. | |||
| metrics_buf: Mutex<Option<Box<dyn Write + Send>>>, | |||
| is_initialized: AtomicBool, | |||
| pub app_metrics: T, | |||
| pub metrics_buf_input: T, | |||
There was a problem hiding this comment.
Mhh, the only reason this name makes sense is because of the todo-comment, which this PR removes. Maybe metrics_data makes more sense?
src/dumbo/src/tcp/endpoint.rs
Outdated
| @@ -79,13 +79,13 @@ pub struct Endpoint { | |||
| // is the only option). | |||
|
|
|||
| impl Endpoint { | |||
| /// Asserts that RCV_BUF_MAX_SIZE <= MAX_WINDOW_SIZE | |||
There was a problem hiding this comment.
Could we instead write a complete doc comment here with a ## Panics: section that mentions this simplifying assumption?
added 2 commits
May 31, 2023 21:00
Signed-off-by: Landon Johnson <[email protected]>
Signed-off-by: Landon Johnson <[email protected]>
Signed-off-by: Landon Johnson <[email protected]>
Signed-off-by: Landon Johnson <[email protected]>
|
Hi @StonewallJohnson , Thanks for your contribution. |
roypat
added a commit
to roypat/firecracker
that referenced
this pull request
May 8, 2024
Resolve a TODO about documenting a panic condition. Closes firecracker-microvm#3636 Signed-off-by: Patrick Roy <[email protected]> Co-Authored-by: Landon Johnson <[email protected]>
roypat
added a commit
to roypat/firecracker
that referenced
this pull request
May 8, 2024
The name is fine. When it was tried to be changed in firecracker-microvm#3636 we could not come up with anything better really. Signed-off-by: Patrick Roy <[email protected]>
roypat
added a commit
to roypat/firecracker
that referenced
this pull request
May 8, 2024
Resolve a TODO about documenting a panic condition. Closes firecracker-microvm#3636 Co-Authored-by: Landon Johnson <[email protected]> Signed-off-by: Patrick Roy <[email protected]>
roypat
added a commit
to roypat/firecracker
that referenced
this pull request
May 8, 2024
The name is fine. When it was tried to be changed in firecracker-microvm#3636 we could not come up with anything better really. Signed-off-by: Patrick Roy <[email protected]>
roypat
added a commit
that referenced
this pull request
May 14, 2024
The name is fine. When it was tried to be changed in #3636 we could not come up with anything better really. Signed-off-by: Patrick Roy <[email protected]>
brandonpike
pushed a commit
to brandonpike/firecracker
that referenced
this pull request
May 20, 2024
Resolve a TODO about documenting a panic condition. Closes firecracker-microvm#3636 Co-Authored-by: Landon Johnson <[email protected]> Signed-off-by: Patrick Roy <[email protected]>
brandonpike
pushed a commit
to brandonpike/firecracker
that referenced
this pull request
May 20, 2024
The name is fine. When it was tried to be changed in firecracker-microvm#3636 we could not come up with anything better really. Signed-off-by: Patrick Roy <[email protected]>
brandonpike
pushed a commit
to brandonpike/firecracker
that referenced
this pull request
May 20, 2024
Resolve a TODO about documenting a panic condition. Closes firecracker-microvm#3636 Co-Authored-by: Landon Johnson <[email protected]> Signed-off-by: Patrick Roy <[email protected]>
brandonpike
pushed a commit
to brandonpike/firecracker
that referenced
this pull request
May 20, 2024
The name is fine. When it was tried to be changed in firecracker-microvm#3636 we could not come up with anything better really. Signed-off-by: Patrick Roy <[email protected]>
brandonpike
pushed a commit
to brandonpike/firecracker
that referenced
this pull request
May 20, 2024
Resolve a TODO about documenting a panic condition. Closes firecracker-microvm#3636 Co-Authored-by: Landon Johnson <[email protected]> Signed-off-by: Patrick Roy <[email protected]>
brandonpike
pushed a commit
to brandonpike/firecracker
that referenced
this pull request
May 20, 2024
The name is fine. When it was tried to be changed in firecracker-microvm#3636 we could not come up with anything better really. Signed-off-by: Patrick Roy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Reason
Resolve TODOs according to #3273
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
CHANGELOG.md.TODOs link to an issue.rust-vmm.