Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add serial console kernel config for aarch64 #3009

Merged
merged 1 commit into from
May 31, 2022
Merged

docs: add serial console kernel config for aarch64 #3009

merged 1 commit into from
May 31, 2022

Conversation

mochja
Copy link
Contributor

@mochja mochja commented May 28, 2022 •
edited
Loading

Reason for This PR

This PR (#1233), states that aarch64 require CONFIG_SERIAL_OF_PLATFORM kernel config, but it's not mentioned in the documentation.

Description of Changes

Mention CONFIG_SERIAL_OF_PLATFORM in the docs.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license.

PR Checklist

[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • The issue which led to this PR has a clear conclusion.
  • This PR follows the solution outlined in the related issue.
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any newly added unsafe code is properly documented.
  • Any API changes follow the Runbook for Firecracker API changes.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

dianpopa
dianpopa reviewed May 30, 2022
View reviewed changes
Copy link
Contributor

@dianpopa dianpopa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

dianpopa
dianpopa previously approved these changes May 30, 2022
View reviewed changes
luminitavoicu
luminitavoicu previously approved these changes May 30, 2022
View reviewed changes
@mochja mochja dismissed stale reviews from luminitavoicu and dianpopa via 5bb8fc5 May 30, 2022 23:12
@luminitavoicu luminitavoicu merged commit 4ed4646 into firecracker-microvm:main May 31, 2022
@mochja mochja deleted the patch-1 branch May 31, 2022 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luminitavoicu luminitavoicu luminitavoicu approved these changes

@dianpopa dianpopa dianpopa approved these changes

Assignees

@mochja mochja

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mochja @dianpopa @luminitavoicu