Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation code does not get rustfmt'd by default #1321

Closed
dianpopa opened this issue Oct 10, 2019 · 1 comment · Fixed by #2866
Closed

Documentation code does not get rustfmt'd by default #1321

dianpopa opened this issue Oct 10, 2019 · 1 comment · Fixed by #2866
Labels
Priority: Low Indicates that an issue or pull request should be resolved behind issues or pull requests labelled ` Status: Blocked Indicates that an issue or pull request cannot currently be worked on

Comments

@dianpopa
Copy link
Contributor

There is a solution to this. Checkout format_code_in_doc_comments in https://github.com/rust-lang/rustfmt/blob/master/Configurations.md but it is not stable yet. We should poll on that and bring it in Firecracker once stable.
@dianpopa dianpopa mentioned this issue Nov 4, 2019
Merged
7 tasks
@alxiord alxiord added the Priority: Low Indicates that an issue or pull request should be resolved behind issues or pull requests labelled ` label Nov 5, 2019
@dianpopa
Copy link
Contributor Author

dianpopa commented Nov 18, 2019 •
edited
Loading

Issue from upstream tracking this.

@alxiord alxiord added the Status: Blocked Indicates that an issue or pull request cannot currently be worked on label Mar 2, 2020
dianpopa added a commit to dianpopa/firecracker that referenced this issue Jan 18, 2022
@dianpopa
rustfmt: format doc comments
393344c 
Fixes firecracker-microvm#1321.

Signed-off-by: Diana Popa <[email protected]>
@dianpopa dianpopa mentioned this issue Jan 18, 2022
Merged
10 tasks
dianpopa added a commit that referenced this issue Jan 18, 2022
@dianpopa
rustfmt: format doc comments
0965ccf 
Fixes #1321.

Signed-off-by: Diana Popa <[email protected]>
gbionescu pushed a commit to gbionescu/firecracker that referenced this issue Feb 9, 2022
@dianpopa @gbionescu
rustfmt: format doc comments
2557de8 
Fixes firecracker-microvm#1321.

Signed-off-by: Diana Popa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: Low Indicates that an issue or pull request should be resolved behind issues or pull requests labelled ` Status: Blocked Indicates that an issue or pull request cannot currently be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rustfmt: format doc comments dianpopa/firecracker
2 participants
@alxiord @dianpopa