remove DCO check on commits in buildkite pipeline #502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Swagat Bora <[email protected]>
henry118
reviewed
Jul 17, 2023
| hostname: "${BUILDKITE_AGENT_META_DATA_HOSTNAME}" | ||
|
|
||
| - label: 'git log validation' | ||
| command: './.buildkite/logcheck.sh' |
Member
There was a problem hiding this comment.
that script also checks fixup commits. will it be migrated and covered by GH actions too?
Contributor
Author
There was a problem hiding this comment.
We can add that check using GH action as well. However, IMO we can just get rid of it. As reviewers we often check the commits and make sure that they are squashed before merging.
henry118
approved these changes
Jul 18, 2023
fangn2
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
We are manually running DCO check on commits as part of our buildkite pipeline. Instead we should enable DCO using https://probot.github.io/apps/dco/ on this repo and removing existing config
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.