Allow --cgroup to be passed to jailer
#493
Conversation
Signed-off-by: Gudmundur Bjarni Olafsson <[email protected]>
Signed-off-by: Gudmundur Bjarni Olafsson <[email protected]>
Signed-off-by: Gudmundur Bjarni Olafsson <[email protected]>
gudmundur
force-pushed
the
jailer-configurable-cgroups
branch
from
7ef891b to
a254341
Compare
Signed-off-by: Guðmundur Bjarni Ólafsson <[email protected]>
Signed-off-by: Guðmundur Bjarni Ólafsson <[email protected]>
|
👋 I'm wanting the same thing, any reason you decided to not pursue this change? Is there a better way to configure cgroups via the SDK? |
|
Likewise, would love to see this in. |
|
@adityamaru we're using this in production. Waiting for a maintainer here to review this. 😳 |
|
@swagatbora90 @austinvazquez Any chance y'all could look into it? Seems like you folks are the most recent contributors on AWS side. Thank you! |
|
@sondavidb Thank you so much for taking a look at #574, could I ask you to take a look at this PR as well? Also, it seems like a bunch of folks would also like this PR landed. Thanks again! |
|
@gudmundur could you rebase and push so the tests can run again? |
|
@gudmundur friendly ping - we would like this feature as well. Are you able to rebase as @sondavidb mentioned? or if you don't have time to look at this, @sondavidb would you be open to me opening a new PR with this change? |
|
Yeah that should be fine, feel free to ping when it is opened |
|
@sondavidb Thanks - I sent #600 |
Description of changes: When setting up the
jailerviafirecracker-go-sdkI noticed that the SDK only supported setting aWithNumaNodeto provide affinity. This change allows theWithNumaNodeto be optional, which it is with thejailer. This change also adds aWithCgroupArgsoption that will pass the provided arguments through tojailers--cgroupargument.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.