Skip to content

Conversation

@niklasmtj
Copy link
Contributor

Issue #, if available: #463

Description of changes:
To get rid of the actions warnings because of Node 12 deprecations this will bump the actions to use Node 16 by default. This closes #463.

I tested it locally with running act. If there is another way to do so please let me know.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

To get rid of the actions working because
of Node 12 deprecations this will bump
the actions to use Node 16 by default.

Signed-off-by: Niklas Metje <[email protected]>
@niklasmtj niklasmtj requested a review from a team as a code owner December 2, 2022 14:42
Copy link
Contributor

@austinvazquez austinvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @niklasmtj for the contribution. The change LGTM.

I have logged #467 for the regression in the buildkite pipeline. Since these changes are isolated to GitHub actions CI no reason to block this PR IMO.

@vvejell1 vvejell1 merged commit 76e7f6e into firecracker-microvm:main Dec 2, 2022
@niklasmtj niklasmtj deleted the chore/update-gh-actions branch December 2, 2022 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Resolve GitHub actions workflow warnings

3 participants