remove logcheck script from buildkite pipeline, use gh workflow instead #758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Swagat Bora <[email protected]>
henry118
approved these changes
Jul 18, 2023
fangn2
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Currently, DCO checks on new commit messages are being run in two places. Once, in the buildkite pipeline using the
logcheck.shscript, another usinggit-validationduringmake lintwhich is run as part of the github workflow.This removes the
logcheck.shscript and only keeps the GH workflow. Buildkite is currently running on main branch only, so DCO check on buildkite is not really useful for newly create PRs. Keeping the GH workflow means that it can run on all new PRsBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.