Skip to content

fix: sanitize build-for-testing path for schemes with spaces, parentheses, etc. #1830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ncooke3 merged 5 commits into from
Dec 16, 2025
Merged

fix: sanitize build-for-testing path for schemes with spaces, parentheses, etc. #1830

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1d5c296
fix: sanitize build-for-testing path for schemes with spaces, parenth…
ncooke3 Dec 16, 2025
7e0e062
style
ncooke3 Dec 16, 2025
8ffecfb
style
ncooke3 Dec 16, 2025
7d5aacb
fixes
ncooke3 Dec 16, 2025
5b724c3
fixes
ncooke3 Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions scripts/build-for-testing.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,15 @@ fi

flags+=( -scheme "$SCHEME" )

# Sanitize SCHEME to be used in file paths
SCHEME_PATH=$(echo "${SCHEME}" | tr -d '()' | tr ' ' '_')
Comment thread
ncooke3 marked this conversation as resolved.

if [[ "$SCHEME" != "$SCHEME_PATH" ]]; then
echo "Sanitized scheme '$SCHEME' to '$SCHEME_PATH' for file paths."
fi

# Set derivedDataPath
DERIVEDDATAPATH="build-for-testing/${SCHEME}"
DERIVEDDATAPATH="build-for-testing/${SCHEME_PATH}"
flags+=( -destination "generic/platform=iOS" -derivedDataPath "$DERIVEDDATAPATH")

# Add extra flags
Expand Down Expand Up @@ -125,6 +132,6 @@ xcb "${flags[@]}"
echo "$message"

# Zip build-for-testing into MyTests.zip
cd "build-for-testing/${SCHEME}/Build/Products"
cd "build-for-testing/${SCHEME_PATH}/Build/Products"
zip -r MyTests.zip Debug-iphoneos ./*.xctestrun
echo "build-for-testing/${SCHEME}/Build/Products zipped into MyTests.zip"
echo "build-for-testing/${SCHEME_PATH}/Build/Products zipped into MyTests.zip"
Loading