Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Go] Added support for flow auth and Firebase auth plugin. #722

Merged
merged 32 commits into from
Aug 8, 2024

Conversation

apascal07
Copy link
Collaborator

@apascal07 apascal07 commented Jul 31, 2024

Fixes #259.

Checklist (if applicable):

  • Tested (manually, unit tested, etc.)
  • Changelog updated
  • Docs updated

@apascal07 apascal07 changed the title [Draft, needs tests] [Go] Added auth to flows. [Go] Added support for flow auth and Firebase auth plugin. Aug 5, 2024
@apascal07 apascal07 marked this pull request as ready for review August 5, 2024 23:13
@apascal07 apascal07 requested review from jba and pavelgj August 5, 2024 23:13
Copy link
Contributor

@jba jba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicer without generics.

go/genkit/flow.go Outdated Show resolved Hide resolved
go/genkit/flow.go Outdated Show resolved Hide resolved
@apascal07 apascal07 requested a review from pavelgj August 7, 2024 15:36
@apascal07 apascal07 requested a review from jba August 7, 2024 15:39
go/genkit/flow.go Outdated Show resolved Hide resolved
go/genkit/flow.go Outdated Show resolved Hide resolved
go/genkit/flow.go Outdated Show resolved Hide resolved
go/genkit/flow.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@pavelgj pavelgj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great job Alex!

@apascal07 apascal07 requested a review from jba August 7, 2024 19:21
docs-go/flows.md Show resolved Hide resolved
docs-go/flows.md Outdated Show resolved Hide resolved
@apascal07 apascal07 merged commit abd71c1 into main Aug 8, 2024
5 checks passed
@apascal07 apascal07 deleted the ap-go-flow branch August 8, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Go] Flow server API payload does not match the JS API
4 participants