Use Vite for v9 updates to the codelab #224
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes for the codelab update
jhuleatt
reviewed
May 11, 2022
jhuleatt
reviewed
Jul 29, 2022
| "eslint": "^4.17.0", | ||
| "prettier": "^1.5.3" | ||
| "prettier": "^1.5.3", | ||
| "vite": "^2.9.6" |
There was a problem hiding this comment.
consider updating to Vite 3 now that it's out
thatfiredev
reviewed
Aug 2, 2022
|
|
||
| async addRating(restaurantID, rating) { | ||
| /* | ||
| TODO: Retrieve add a rating to a restaurant |
There was a problem hiding this comment.
Suggested change
| TODO: Retrieve add a rating to a restaurant | |
| TODO: Add a rating to a restaurant |
jhuleatt
reviewed
Aug 4, 2022
Comment on lines
+19
to
+21
| firebase.initializeApp({ | ||
| /* Enter your config here */ | ||
| }); |
There was a problem hiding this comment.
Can this import from scripts/config.js just like app.js does?
|
Does |
jhuleatt
reviewed
Aug 4, 2022
Comment on lines
+1
to
+5
| export const config = { | ||
| firebase: { | ||
| /* Enter your config here */ | ||
| } | ||
| }; |
There was a problem hiding this comment.
FriendlyChat throws an error if config isn't provided. Want to do the same thing here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.