Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[firebase_admob] Fixes memory leak by removing static reference for Activities #35

Closed
wants to merge 4 commits into from
Closed

[firebase_admob] Fixes memory leak by removing static reference for Activities #35

wants to merge 4 commits into from

Conversation

collinjackson
Copy link
Contributor

@collinjackson collinjackson commented Aug 26, 2019 •
edited
Loading

Migration of flutter/plugins#1943 by @BugsBunnyBR

@collinjackson collinjackson mentioned this pull request Aug 26, 2019
Closed
13 tasks
bparrishMines
bparrishMines approved these changes Aug 29, 2019
View reviewed changes
Copy link
Contributor

@bparrishMines bparrishMines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@urbanjagodic urbanjagodic mentioned this pull request Sep 9, 2019
Closed
@YonatanAmitzur YonatanAmitzur mentioned this pull request Sep 16, 2019
Closed
@juliocbcotta
Copy link
Contributor

@collinjackson what do we need to get this merged?

@collinjackson
Copy link
Contributor Author

I think this is probably ok to land, just waiting to for the tests to re-run. Thank you.

@juliocbcotta
Copy link
Contributor

@collinjackson , let's merge it! :-D

@exilonX exilonX mentioned this pull request Oct 16, 2019
Closed
@agnoam agnoam mentioned this pull request Oct 23, 2019
Closed
@Parmendrakumar Parmendrakumar mentioned this pull request Nov 5, 2019
Closed
@PrismaSoftGC PrismaSoftGC mentioned this pull request Nov 5, 2019
Closed
@IvanOnishchenko IvanOnishchenko mentioned this pull request Nov 6, 2019
Closed
@habtish1 habtish1 mentioned this pull request Nov 7, 2019
Closed
@Sonderman Sonderman mentioned this pull request Nov 18, 2019
Closed
@amitverma-cf amitverma-cf mentioned this pull request Nov 18, 2019
Closed
@boylenssen boylenssen mentioned this pull request Nov 20, 2019
Closed
@emailsubjekt emailsubjekt mentioned this pull request Dec 9, 2019
Closed
@NickM-27 NickM-27 mentioned this pull request Dec 12, 2019
Closed
@jcvw75 jcvw75 mentioned this pull request Dec 13, 2019
Closed
@yousaywhat yousaywhat mentioned this pull request Dec 23, 2019
Closed
@monkeyidesign monkeyidesign mentioned this pull request Dec 25, 2019
Closed
@ziasultan2 ziasultan2 mentioned this pull request Jan 1, 2020
Closed
@emailsubjekt emailsubjekt mentioned this pull request Jan 2, 2020
Closed
@callumclift callumclift mentioned this pull request Jan 10, 2020
Closed
@craigbennett1981 craigbennett1981 mentioned this pull request Jan 28, 2020
Closed
@trqalothman trqalothman mentioned this pull request Jan 30, 2020
Closed
@asharora asharora mentioned this pull request Feb 27, 2020
Closed
@igorantolic igorantolic mentioned this pull request Mar 11, 2020
Closed
@munene5470 munene5470 mentioned this pull request Mar 12, 2020
Closed
@ClevercodeTech ClevercodeTech mentioned this pull request Mar 16, 2020
Closed
@motorahul motorahul mentioned this pull request Mar 20, 2020
Closed
@peterkuch peterkuch mentioned this pull request Mar 22, 2020
Closed
@mudi256 mudi256 mentioned this pull request Mar 23, 2020
Closed
@shojaeddin shojaeddin mentioned this pull request Apr 3, 2020
Closed
@aliheader aliheader mentioned this pull request Apr 3, 2020
Closed
@vineetpandit90 vineetpandit90 mentioned this pull request Apr 17, 2020
Closed
@ishtms ishtms mentioned this pull request Apr 17, 2020
Closed
@zameerhossain zameerhossain mentioned this pull request Apr 28, 2020
Closed
@YashMobileFirst YashMobileFirst mentioned this pull request Apr 28, 2020
Closed
@navigui navigui mentioned this pull request Apr 30, 2020
Closed
@besidesordinary besidesordinary mentioned this pull request May 5, 2020
Closed
@sunilcoder36 sunilcoder36 mentioned this pull request May 6, 2020
Closed
@Niccolohui Niccolohui mentioned this pull request May 8, 2020
Closed
@momo1606 momo1606 mentioned this pull request Jun 2, 2020
Closed
@aislingorg aislingorg mentioned this pull request Jun 3, 2020
Closed
@MassiveSuccess MassiveSuccess mentioned this pull request Jun 7, 2020
Closed
@bytejutsu bytejutsu mentioned this pull request Jun 12, 2020
Closed
@sumanthkumarps sumanthkumarps mentioned this pull request Jul 5, 2020
Closed
@itssidhere itssidhere mentioned this pull request Aug 18, 2020
Closed
@firebase firebase locked and limited conversation to collaborators Aug 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bparrishMines bparrishMines bparrishMines approved these changes

@amirh amirh Awaiting requested review from amirh

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@collinjackson @juliocbcotta @bparrishMines @googlebot