-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[firebase_messaging] check permissions #20
Closed
wwwdata
wants to merge
2
commits into
firebase:master
from
thesoftwarefanatics:firebase-messaging-check-permissions
Closed
[firebase_messaging] check permissions #20
wwwdata
wants to merge
2
commits into
firebase:master
from
thesoftwarefanatics:firebase-messaging-check-permissions
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwwdata
changed the title
Firebase messaging check permissions
[firebase_messaging] check permissions
Aug 23, 2019
This PR has conflicts against master branch, please resolve them first. |
wwwdata
force-pushed
the
firebase-messaging-check-permissions
branch
from
August 28, 2019 07:29
7474c42
to
b86dd77
Compare
Ping @collinjackson @kroikie |
@wwwdata Many thanks for this PR. We try to keep the API as close to the native SDKs as possible. I think this is indeed a useful feature but I don't think it is something that should be part of the FCM plugin. I think the Flutter framework would be a better fit for a system specific API like this one. |
Closed
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change introduces a method call for iOS to check whether the user has previously accepted or declined the push notification setting. This is useful to check it later in the app and then remind the user to enable the push notifications manually in the control center, because the initial request permissions dialog is only displayed once. Or if the user changed the permissions in the Settings, and switches back to the app, the
onIosSettingsRegistered
event is also not fired.Related Issues
I stuck to the old API, if flutter/plugins#1009 is merged in, this should also be updated to use the new UNUserNotificationCenter
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?