Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[firebase_dynamic_links] Plugin should not crash if activity is unavailable #7

Closed
mehmetf opened this issue Aug 21, 2019 · 1 comment

Comments

@mehmetf
Copy link
Contributor

mehmetf commented Aug 21, 2019

See: flutter/plugins#1989

Currently, if registrar.activity() is not there, the plugin crashes. This is a legitimate use case for some apps since they invoke the Dart isolate from application class (as opposed to activity). We should avoid using activity if we can (e.g. we don't need it for Task objects).

@mehmetf
Copy link
Contributor Author

mehmetf commented Aug 25, 2019

Fixed with #14

@mehmetf mehmetf closed this as completed Aug 25, 2019
kroikie pushed a commit that referenced this issue Jul 3, 2020
Co-authored-by: ehesp <[email protected]>
Co-authored-by: Kirsty Williams <[email protected]>
Co-authored-by: Helena Ford <[email protected]>
Co-authored-by: Kirsty Williams <[email protected]>
Co-authored-by: Greg Hesp <[email protected]>
@firebase firebase locked and limited conversation to collaborators Aug 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant