Skip to content

Fix Android Testapp build timeout & some code cleaning #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jun 30, 2022
Merged

Fix Android Testapp build timeout & some code cleaning #391

merged 10 commits into from
Jun 30, 2022

Conversation

@sunmou99
Copy link
Contributor

@sunmou99 sunmou99 commented Jun 30, 2022 •
edited
Loading

Description

  1. reverted unity ndk setting, which caused android testapp build timeout.
  2. some code cleaning.

Testing

Describe how you've tested these changes.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

@sunmou99 sunmou99 changed the title Bugfix/android ndk Fix Android Testapp build timeout & some code cleaning Jun 30, 2022
@sunmou99 sunmou99 marked this pull request as ready for review June 30, 2022 20:46
@sunmou99 sunmou99 merged commit 7a13328 into main Jun 30, 2022
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Jun 30, 2022
@github-actions
Copy link

github-actions bot commented Jun 30, 2022

⏳  Integration test in progress...

Requested by @sunmou99 on commit 7a13328
Last updated: Thu Jun 30 16:55 PDT 2022
View integration test log & download artifacts

@firebase firebase locked and limited conversation to collaborators Jul 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cynthiajoan cynthiajoan cynthiajoan approved these changes

@a-maurice a-maurice a-maurice approved these changes

Assignees

No one assigned

Labels

tests: in-progress This PR's integration tests are in progress.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sunmou99 @cynthiajoan @a-maurice