-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Schnecle/crashlytics resources exploration #9621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Schnecle/crashlytics resources exploration #9621
Conversation
Summary of ChangesHello @schnecle, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refactors and enhances the Crashlytics integration by consolidating reporting tools, introducing a comprehensive set of resource guides, and improving error handling across Crashlytics-related functionalities. The changes aim to provide a more structured, efficient, and user-friendly experience for interacting with Crashlytics data, guiding the agent through complex tasks with clear, externalized documentation. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request significantly refactors the Crashlytics integration by moving lengthy instructions from prompts into modular, reusable resource guides. This greatly improves maintainability and clarity. The consolidation of multiple report-fetching tools into a single, more robust get_report tool is another major improvement. Error handling within the tools has also been enhanced to provide more contextual feedback to the agent. The overall code quality is high, with good improvements in style and robustness. I have a couple of minor suggestions to further polish the changes.
| .describe("Firebase App Id. Strictly required for all API calls."); | ||
|
|
||
| export const IssueIdSchema = z.string().describe("Crashlytics issue id, as hexidecimal uuid"); | ||
| export const IssueIdSchema = z.string().describe("Crashlytics issue id, as hexidecimal UUID"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| * When investigating an issue, use the appropriate top devices and top operating systems reports to understand what systems are impacted by the problem. Pass the "issueId" in the filter to narrow any report to a specific issue. | ||
| ### Formatting Reports |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a830e87 to
6664f49
Compare
…formatting. Also update tool descriptions to encourage resource reading.
6664f49 to
ce6b53e
Compare
|
Absorbed into PR 9594 |
Description
This is playing around with removing more instructions but emphasizing formatting and getting tool calls to encourage resource reading without the introduction of a session id.
Scenarios Tested
/crashlytics:connect
Manually asking to investigate an individual issue and fetching reports.