Upgrades functions::list command to utilize Cloud Run API #9425

brittanycho · 2025-10-31T22:30:33Z

Upgrades functions::list command to utilize Cloud Run API:

Upgrades by adding new function (listServices) to runV2.ts and defining trigger within endpointFromService function. Then listServices and endpointFromService are newly utilized in functions-list.ts so that this command now uses cloud run api

gemini-code-assist · 2025-10-31T22:30:49Z

Summary of Changes

Hello @brittanycho, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the functions:list command to leverage the Cloud Run API for listing functions. This change enables the command to accurately retrieve and display Cloud Run-based functions, providing more detailed trigger information and improving the overall user experience for managing serverless deployments.

Highlights

Cloud Run API Integration: The functions:list command has been upgraded to utilize the Cloud Run API for retrieving and displaying functions, moving away from the previous Cloud Functions backend.
New listServices Function: A new asynchronous function, listServices, has been added to src/gcp/runv2.ts to fetch all Cloud Run services for a given project, including robust pagination handling.
Enhanced Trigger Detection: The endpointFromService function in src/gcp/runv2.ts has been updated to accurately determine and define trigger types (HTTP or event-based) for functions based on service annotations.
Permission Update: The functions:list command now requires the run.services.list permission, reflecting its reliance on the Cloud Run API.
Output Table Refinement: The functions:list command's output table has been modified to replace the 'Version' column with 'Platform', providing more relevant information for Cloud Run services.
Comprehensive Testing for listServices: New unit tests have been added in src/gcp/runv2.spec.ts to ensure the listServices function correctly fetches services, handles pagination, and manages API errors.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request updates the functions:list command to use the Cloud Run API, which is a significant improvement. The implementation looks solid, with good test coverage for the new listServices function. I have a couple of suggestions to improve type safety and error logging.

src/commands/functions-list.ts

src/gcp/runv2.ts

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

brittanycho · 2025-11-05T22:52:14Z

/gemini review

gemini-code-assist

Code Review

This pull request successfully upgrades the functions::list command to use the Cloud Run API, which is a great improvement for supporting Cloud Run-based functions. I've found a critical issue where GCFv2 functions could be duplicated in the list, and I've provided a fix. I also have a minor suggestion to improve performance in the new listServices function. Overall, the changes are well-structured and the tests for the new functionality are thorough.

src/commands/functions-list.ts

src/gcp/runv2.ts

merge

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

taeold · 2025-11-07T16:00:04Z

src/commands/functions-list.ts

+    let v2Endpoints: backend.Endpoint[] = [];
+    try {
+      const services = await listServices(projectId);
+      v2Endpoints = services.map((service) => endpointFromService(service));
+    } catch (err: any) {
+      logger.debug(`Failed to list v2 functions:`, err);
+      logger.warn(
+        `Failed to list v2 functions. Ensure you have the Cloud Run Admin API enabled and the necessary permissions.`,


I think this entire logic should live inside backend.existingBackend(context)

existingBackend is the abstraction we have that calls GCF v1/v2 API and then transform it into a common representation. We should add support for Run functions there directly (which would benefit this command along with other places where we need to list functions (e.g. during deploy)

taeold · 2025-11-07T16:02:40Z

src/commands/functions-list.ts

      const entry = [
        endpoint.id,
-        endpoint.platform === "gcfv2" ? "v2" : "v1",
+        endpoint.platform === "gcfv2" ? "v2" : endpoint.platform === "run" ? "run" : "v1",


hmm maybe we can use a small map, like PLATFORM_TO_DISPLAY_NAME or something?

type PLATFORM_DISPLAY_NAME = "v1" | "v2" | "run";
const PLATFORM_TO_DISPLAY_NAME: Record<type endpoint.platform, PLATFORM_DISPLAY_NAME> = {
gcfv1: "v1",
gcfv2: "v2",
run: "run",
};

// Returns 'v2', 'run', or falls back to 'v1'
const version = platformMap[endpoint.platform]

taeold · 2025-11-07T16:03:32Z

src/gcp/runv2.spec.ts

    });
  });
+
+  describe("listServices", () => {


looks like its missing test on whether filtering by label works correctly

taeold · 2025-11-07T16:04:45Z

src/commands/functions-list.ts

+
+    let v2Endpoints: backend.Endpoint[] = [];
+    try {
+      const services = await listServices(projectId);


it looks like this would list all Run services, which is not what we want.

brittanycho added 3 commits October 31, 2025 22:20

adds listServices fn and adds trigger to endpointFromService fn

12b9257

updates functions-list to use listServices to use cloud run api instead

0a30722

adds listServices tests

df189ee

github-project-automation bot added this to [Cloud] Extensions + Functions Oct 31, 2025

gemini-code-assist bot reviewed Oct 31, 2025

View reviewed changes

src/commands/functions-list.ts Outdated Show resolved Hide resolved

src/gcp/runv2.ts Outdated Show resolved Hide resolved

fix linting errors

66cf473

brittanycho changed the title ~~Fr/cloud run fns list~~ Upgrades functions::list command to utilize Cloud Run API Oct 31, 2025

brittanycho and others added 3 commits October 31, 2025 22:39

Merge branch 'master' into fr/cloud-run-fns-list

3af536c

Update src/commands/functions-list.ts

f6ef8c0

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Update src/gcp/runv2.ts

d9fd843

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

brittanycho requested a review from taeold November 3, 2025 22:17

brittanycho added 3 commits November 3, 2025 23:41

corrects import error

84725cf

add relevant labelSelectors

6a45457

adding v1 fns in

9cedf12

gemini-code-assist bot reviewed Nov 5, 2025

View reviewed changes

src/commands/functions-list.ts Outdated Show resolved Hide resolved

src/gcp/runv2.ts Outdated Show resolved Hide resolved

brittanycho and others added 5 commits November 5, 2025 23:06

adding in deduplication

481d02f

Merge branch 'master' into fr/cloud-run-fns-list

0362303

merge

Update src/gcp/runv2.ts

d4ed0f9

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

linting

2de426f

Merge branch 'master' into fr/cloud-run-fns-list

7cb75d8

taeold requested changes Nov 7, 2025

View reviewed changes

github-project-automation bot moved this to Changes Requested [PR] in [Cloud] Extensions + Functions Nov 7, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Upgrades functions::list command to utilize Cloud Run API #9425

Upgrades functions::list command to utilize Cloud Run API #9425

brittanycho commented Oct 31, 2025

Uh oh!

gemini-code-assist bot commented Oct 31, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

Uh oh!

brittanycho commented Nov 5, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

Uh oh!

taeold Nov 7, 2025

Uh oh!

taeold Nov 7, 2025

Uh oh!

taeold Nov 7, 2025

Uh oh!

taeold Nov 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Upgrades functions::list command to utilize Cloud Run API #9425

Are you sure you want to change the base?

Upgrades functions::list command to utilize Cloud Run API #9425

Conversation

brittanycho commented Oct 31, 2025

Uh oh!

gemini-code-assist bot commented Oct 31, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

brittanycho commented Nov 5, 2025

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

taeold Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

taeold Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

taeold Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

taeold Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants