App Hosting Emulator: Change startCommandOverride to startCommand

schema/firebase-config.json

@@ -369,7 +369,7 @@
                         "rootDirectory": {
                             "type": "string"
                         },
-                        "startCommandOverride": {
+                        "startCommand": {
                             "type": "string"
                         }
                     },

src/emulator/apphosting/developmentServer.ts

@@ -14,7 +14,7 @@
 /**
  * Returns the package manager used by the project
  * @param rootdir project's root directory
  * @returns PackageManager
  */
 export async function detectPackageManager(rootdir: string): Promise<PackageManager> {
   if (await pathExists(join(rootdir, "pnpm-lock.yaml"))) {
@@ -32,13 +32,13 @@
   throw new FirebaseError("Unsupported package manager");
 }
 
 export async function detectStartCommand(rootDir: string) {
   try {
     const packageManager = await detectPackageManager(rootDir);
     return `${packageManager} run dev`;
   } catch (e) {
     throw new FirebaseError(
-      "Failed to auto-detect your project's start command. Consider manually setting the start command by setting `firebase.json#emulators.apphosting.startCommandOverride`",
+      "Failed to auto-detect your project's start command. Consider manually setting the start command by setting `firebase.json#emulators.apphosting.startCommand`",
     );
   }
 }

src/emulator/apphosting/index.ts

@@ -2,10 +2,10 @@
 import { start as apphostingStart } from "./serve";
 import { logger } from "./developmentServer";
 interface AppHostingEmulatorArgs {
   options?: any;
   port?: number;
   host?: string;
-  startCommandOverride?: string;
+  startCommand?: string;
   rootDirectory?: string;
 }
 
@@ -19,11 +19,11 @@
   async start(): Promise<void> {
     const { hostname, port } = await apphostingStart({
       port: this.args.port,
-      startCommand: this.args.startCommandOverride,
+      startCommand: this.args.startCommand,
       rootDirectory: this.args.rootDirectory,
     });
     this.args.options.host = hostname;
     this.args.options.port = port;
   }
 
   connect(): Promise<void> {
@@ -39,8 +39,8 @@
   getInfo(): EmulatorInfo {
     return {
       name: Emulators.APPHOSTING,
       host: this.args.options.host!,
       port: this.args.options.port!,
     };
   }
 

src/emulator/controller.ts

@@ -955,7 +955,7 @@ export async function startAll(
     const apphostingEmulator = new AppHostingEmulator({
       host: apphostingAddr.host,
       port: apphostingAddr.port,
-      startCommandOverride: apphostingConfig?.startCommandOverride,
+      startCommand: apphostingConfig?.startCommand,
       rootDirectory: apphostingConfig?.rootDirectory,
       options,
     });

src/emulator/initEmulators.ts

@@ -30,11 +30,11 @@ export const AdditionalInitFns: AdditionalInitFnsType = {
     const backendRoot = join(cwd, backendRelativeDir);
     try {
       const startCommand = await detectStartCommand(backendRoot);
-      additionalConfigs.set("startCommandOverride", startCommand);
+      additionalConfigs.set("startCommand", startCommand);
     } catch (e) {
       logger.log(
         "WARN",
-        "Failed to auto-detect your project's start command. Consider manually setting the start command by setting `firebase.json#emulators.apphosting.startCommandOverride`",
+        "Failed to auto-detect your project's start command. Consider manually setting the start command by setting `firebase.json#emulators.apphosting.startCommand`",
       );
     }
 

src/firebaseConfig.ts

@@ -206,7 +206,7 @@ export type EmulatorsConfig = {
   apphosting?: {
     host?: string;
     port?: number;
-    startCommandOverride?: string;
+    startCommand?: string;
     rootDirectory?: string;
   };
   pubsub?: {