App hosting should support pnpm workspace projects

[debkanchan]

[REQUIRED] Environment info

firebase-tools: 13.13.0

Platform: MacOS

[REQUIRED] Test case

Steps to reproduce should be enough

[REQUIRED] Steps to reproduce

1. Create a new pnpm workspace with the following pnpm-workspace.yaml

packages:
  - "apps/*"
  - "packages/*"

2. inside /apps/main init a new nextjs app
3. inside /packages/random init empty js project
4. in project root run pnpm i
5. commit and push to Github
6. create new app hosting backend, specify app directory to /apps/main

[REQUIRED] Expected behaviour

Deploys the app

[REQUIRED] Actual behaviour

failed to build, lockfile not found

[google-oss-bot]

This issue does not seem to follow the issue template. Make sure you provide all the required information.

[aalej]

Hey @debkanchan, thanks for reaching out and for providing a detailed report. I discussed this with our engineering team. Currently, pnpm is supported, however pnpm workspaces is not. For now, I’ll mark this as a feature request.

[benyap]

Hi @aalej, just thought I'd chip in and mention a similar discussion that was started here: #7206 (reply in thread)

Looking forward to see official support for pnpm workspaces at some point in the future.

[juanmosv]

supporting pnpm monorepo is a must +1

[Xennis]

+1 for this.

PS: A workaround is to set shared-workspace-lockfile to false.

[KalebKloppe]

A workaround is to set shared-workspace-lockfile to false.

This does solve one error, but I still get other errors for missing pnpm workspace packages.

App Hosting Build Error

Type error: Cannot find module 'ui/components/Heading' or its corresponding type declarations.

Project Structure

    ├── apps
    │   └── web
    │       ├── package.json
    │       └── package.json
    ├── shared
    │   └── ui
    │       ├── pnpm-lock.yaml
    │       └── package.json
    ├── pnpm-workspace.yaml
    ├── pnpm-lock.yaml
    └── package.json

apps/web/package.json

  "dependencies": {
    "ui": "workspace:*",
    "utils": "workspace:*",
  },

[iSuslov]

+1, turborepo also should be supported

[huksley]

What is the status of this? All types of monorepo should be supported - pnpm, turborepo and npm workspaces as well.