Skip to content

[Auth] Make the persistences default to inMemory for node #5527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 22, 2021
Merged

[Auth] Make the persistences default to inMemory for node #5527

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0aeda3c
Make the persistences default to inMemory for node
sam-gc Sep 21, 2021
a987c94
Add changeset
sam-gc Sep 21, 2021
1baa761
Update changeset to be "minor" instead of "patch"
sam-gc Sep 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/swift-shirts-appear.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@firebase/auth": minor
---

Update all persistences to map to `inMemoryPersistence` in Node, to avoid errors with server-side rendering
8 changes: 4 additions & 4 deletions packages/auth/src/platform_node/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import { _createError } from '../core/util/assert';
import { FirebaseApp, getApp, _getProvider } from '@firebase/app';
import { Auth } from '../model/public_types';

import { initializeAuth } from '..';
import { initializeAuth, inMemoryPersistence } from '..';
import { registerAuth } from '../core/auth/register';
import { ClientPlatform } from '../core/util/version';
import { AuthImpl } from '../core/auth/auth_impl';
Expand Down Expand Up @@ -76,9 +76,9 @@ class FailClass {
}
}

export const browserLocalPersistence = NOT_AVAILABLE_ERROR;
export const browserSessionPersistence = NOT_AVAILABLE_ERROR;
export const indexedDBLocalPersistence = NOT_AVAILABLE_ERROR;
export const browserLocalPersistence = inMemoryPersistence;
export const browserSessionPersistence = inMemoryPersistence;
export const indexedDBLocalPersistence = inMemoryPersistence;
export const browserPopupRedirectResolver = NOT_AVAILABLE_ERROR;
export const PhoneAuthProvider = FailClass;
export const signInWithPhoneNumber = fail;
Expand Down