Skip to content

Version Patch for Firebase Admin #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 21, 2018
Merged

Version Patch for Firebase Admin #524

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
19e704a
Patch the version info and the firebase.SDK_VERSION
jshcrowthe Feb 20, 2018
cf51403
[AUTOMATED]: Prettier Code Styling
jshcrowthe Feb 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions packages/database/index.node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
*/

import firebase from '@firebase/app';
import { CONSTANTS, isNodeSdk } from '@firebase/util';
import { FirebaseApp, FirebaseNamespace } from '@firebase/app-types';
import { _FirebaseNamespace } from '@firebase/app-types/private';
import { Database } from './src/api/Database';
Expand All @@ -24,7 +25,6 @@ import { enableLogging } from './src/core/util/util';
import { RepoManager } from './src/core/RepoManager';
import * as INTERNAL from './src/api/internal';
import * as TEST_ACCESS from './src/api/test_access';
import { isNodeSdk } from '@firebase/util';
import './src/nodePatches';
import * as types from '@firebase/database-types';

Expand All @@ -38,7 +38,16 @@ import * as types from '@firebase/database-types';

const ServerValue = Database.ServerValue;

export function initStandalone(app, url) {
export function initStandalone(app, url, version?: string) {
/**
* This should allow the firebase-admin package to provide a custom version
* to the backend
*/
CONSTANTS.NODE_ADMIN = true;
if (version) {
firebase.SDK_VERSION = version;
}

return {
instance: RepoManager.getInstance().databaseFromApp(app, url),
namespace: {
Expand Down