Skip to content

Conversation

@dconeybe
Copy link
Contributor

These inconsistencies cause warnings when the code is copied into google3 via copybara.

#no-changelog

@dconeybe dconeybe self-assigned this Mar 24, 2022
@dconeybe dconeybe requested a review from wu-hui March 24, 2022 17:09
@google-oss-bot
Copy link

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestore.framework

    Overall coverage changed from 86.64% (6efe4f5) to 86.59% (75a13f1) by -0.05%.

    FilenameBase (6efe4f5)Merge (75a13f1)Diff
    exception.cc73.68%23.68%-50.00%
    exception_apple.mm58.62%89.66%+31.03%
    leveldb_key.cc98.60%98.81%+0.22%
    ordered_code.cc94.15%93.41%-0.73%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/qModvk4VNO.html

@wu-hui wu-hui merged commit 6a23442 into master Mar 25, 2022
@wu-hui wu-hui deleted the dconeybe/IndexGoogleWarningFixes branch March 25, 2022 15:00
@firebase firebase locked and limited conversation to collaborators Apr 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants